Remove PG_INDEXER feature flag and drop obsolete code #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habdelra
changed the title
habdelra
commented
May 10, 2024
Host Tests (In-Memory Index) Test Results 1 files ±0 1 suites ±0 14m 22s ⏱️ + 3m 11s For more details on these errors, see this check. Results for commit cdb8083. ± Comparison against base commit 0821c54. This pull request skips 1 and un-skips 2 tests.♻️ This comment has been updated with latest results. |
…e-flag-pg-indexer-and-cleanup-obsolete-code
habdelra
requested review from
lukemelia,
backspace,
IanCal,
jurgenwerk,
ef4,
tintinthong,
FadhlanR and
burieberry
habdelra
commented
May 10, 2024
Comment on lines
-886
to
-894
| // allow any WIP index requests to query the index while it's building up | ||
| if (!request.headers.get('X-Boxel-Use-WIP-Index')) { | ||
| await this.ready; | ||
| } |
There was a problem hiding this comment.
turns out I was using the loader wrong. the realm's loader has the internal fetch URL handler. once I started passing a clone of that to the worker then this condition became unnecessary
habdelra
commented
May 10, 2024
Comment on lines
+1088
to
+1093
| `${message}. created a new generation while there was still unfinished indexing. ` + | ||
| `The most likely reason this happens is that there was an error encountered during incremental ` + | ||
| `indexing that prevented the indexing from completing (and realm version increasing), ` + | ||
| `then the realm was restarted and the left over WIP indexing artifact(s) collided with the ` + | ||
| `from-scratch indexing. To resolve this issue delete the WIP indexing artifacts (the row(s) ` + | ||
| `that triggered the unique constraint) and restart the realm.`; |
There was a problem hiding this comment.
trying to win the oscar for best error message 😆
backspace
approved these changes
May 11, 2024
Comment on lines
+1088
to
+1093
| `${message}. created a new generation while there was still unfinished indexing. ` + | ||
| `The most likely reason this happens is that there was an error encountered during incremental ` + | ||
| `indexing that prevented the indexing from completing (and realm version increasing), ` + | ||
| `then the realm was restarted and the left over WIP indexing artifact(s) collided with the ` + | ||
| `from-scratch indexing. To resolve this issue delete the WIP indexing artifacts (the row(s) ` + | ||
| `that triggered the unique constraint) and restart the realm.`; |
| @@ -937,6 +829,9 @@ export class Realm { | |||
| return undefined; | |||
| } | |||
|
|
|||
| // TODO we could really improve performance if this utilized the index instead | |||
| // of directly hitting the filesystem--especially the TS transpilation | |||
| // involved in making JS. | |||
There was a problem hiding this comment.
is this a full project or could an issue be opened for it?
There was a problem hiding this comment.
I think it’s probably a project
|
hmm actually I approved before I saw these |
No prob, that’s my Monday work |
Co-authored-by: Buck Doyle <[email protected]>
…e-flag-pg-indexer-and-cleanup-obsolete-code
…lete-code' of https://github.com/cardstack/boxel into cs-6719-remove-feature-flag-pg-indexer-and-cleanup-obsolete-code
delete-merged-branch
bot
deleted the
cs-6719-remove-feature-flag-pg-indexer-and-cleanup-obsolete-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.