Create country field with dropdown edit mode #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tintinthong
force-pushed
the
introduce-country-dropdown
branch
from
ee69385 to
df2865a
Compare
Host Test Results 1 files ± 0 1 suites ±0 38m 11s ⏱️ + 18m 27s For more details on these failures, see this check. Results for commit 0ade0a2. ± Comparison against base commit 3400152. ♻️ This comment has been updated with latest results. |
tintinthong
changed the title
tintinthong
changed the title
lukemelia
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a country field which is a field definition but it gets data of country codes from a cdn. This is meant to support the form filling of an address field https://linear.app/cardstack/issue/CS-7410/refine-address-field
Before we have feature of data realms, we would need this to enumerate fields inside of a dropdown
Possible alternatives
We can also hardcode the data inside of the country field itself