Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplyButton component for AI Assistant panel #974

Merged
merged 3 commits into from
Jan 24, 2024
Merged

ApplyButton component for AI Assistant panel #974

merged 3 commits into from
Jan 24, 2024

Conversation

lukemelia
Copy link
Contributor

@lukemelia lukemelia commented Jan 16, 2024 •
edited
Loading

Screen.Recording.2024-01-17.at.4.18.59.PM.mov

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2024 •
edited
Loading

Test Results

490 tests  ±0   486 ✔️ ±0   6m 52s ⏱️ +23s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit d19d0ff. ± Comparison against base commit 76fbc0b.

♻️ This comment has been updated with latest results.

@lukemelia lukemelia changed the title WIP ApplyButton component for AI Assistant panel ApplyButton component for AI Assistant panel Jan 17, 2024
@lukemelia lukemelia marked this pull request as ready for review January 17, 2024 21:23
burieberry
burieberry approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@burieberry burieberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I wonder if the css animation would still work fine if the icons were in boxel-ui package and we just added the class names on them here.

@lukemelia
Copy link
Contributor Author

Looks great! I wonder if the css animation would still work fine if the icons were in boxel-ui package and we just added the class names on them here.

I'll try to make that work

@lukemelia lukemelia force-pushed the ai-apply-button branch 3 times, most recently from 7404e00 to 3c0605d Compare January 22, 2024 22:49
@lukemelia
Copy link
Contributor Author

@burieberry ready for another round

@lukemelia lukemelia requested a review from burieberry January 23, 2024 00:00
@lukemelia lukemelia merged commit daaa359 into main Jan 24, 2024
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ai-apply-button branch January 24, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FadhlanR FadhlanR FadhlanR approved these changes

@burieberry burieberry burieberry approved these changes

@jurgenwerk jurgenwerk Awaiting requested review from jurgenwerk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukemelia @FadhlanR @burieberry