-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add horizontal resize of ai chat panel #983
Conversation
I’m not sure of the boundaries of this and other issues, maybe this is 6485, but I noticed I’m unable to scroll the messages container and when I tab to the field to add another message everything shifts upward: The proximity detection for showing and highlighting the handle is great, I found the snapping at the minimal width a bit jarring, unclear how that could be improved though |
I also meant to ask: I’d expect the open/closed state of the panel to be persistent across refreshes, as well as its width. I don’t see an open issue for this and realise it’s not in the issue as defined though! |
@backspace , Thank you for the feedback. I've addressed the scroll issue in the AI Assistant panel and added a Screen.Recording.2024-01-19.at.11.51.26.mov |
@backspace do you think it is better to make the open/closed and width state persistent in this PR? |
I’m uncertain! Let’s just say leave it for now, something to consider for the future. The scrolling and non-collapse look good, thanks! ETA something seems to be terribly wrong with the tests and therefore Percy, let us know when it’s ready again |
8b67bcc
to
1151ac5
Compare
I've fixed boxel ui test and host test. This PR is ready for another review. cc: @backspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, I appreciate all the refinements 🎉
packages/boxel-ui/addon/src/components/resizable-panel-group/index.gts
Outdated
Show resolved
Hide resolved
Is the ResizeHandler component the thing responsible for rendering the handle? If so, should it be called ResizeHandle instead of ResizeHandler? I usually think of a "handler" as something that responds to events being triggered. |
@jurgenwerk I've added minimum length and made Screen.Recording.2024-01-23.at.14.32.47.mov |
Ticket: CS-6430
Screen.Recording.2024-01-18.at.14.35.26.mov