ui: Move tooltips to overlay #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a truncation in Safari.
|
Unfortunately this breaks some test expectations. The tooltips are indeed showing but even when I adjust the assertions the elements can’t be found, presumably because it’s outside the test container.
I’m unsure what best practice is here for finding the right container, part of the difficulty is because ETA: |
This allows it to work in a test context.
lukemelia
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the truncation in Safari seen in the top window here:
The
Tooltipcomponent inboxel-uifinds or inserts an overlay element for tooltips to be inserted into. To make tests that make assertions about tooltips the overlay is inserted onowner.rootElementdespite that being undocumented API.