Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleClick GUI improvements #379

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mapedorr
Copy link
Collaborator

@mapedorr mapedorr commented Jan 5, 2025

simple_click_settings_popup_02.mp4

Based on the update proposed in #373 for the SimpleClick GUI, this PR makes that GUI to use only a bar with the inventory and a button to open a settings popup.

Tasks

  • Create a bar with the inventory and a settings button.
  • Create the Settings popup.
  • Create a Migration script that updates the game GUI in case it is using the SimpleClick template.
    • Remove the InventoryBar, SettingsBar, TextSettingsPopup and SoundSettingsPopup.
    • Add the SimpleClickBar component and the SimpleClickSettingsPopup.
    • Update the SaveAndLoadPopup.
    • Check for potential issues in the migration process.

@mapedorr mapedorr force-pushed the feature/373-simple-click-gui-improvements branch from e750a9e to a26e53f Compare January 10, 2025 10:36
These components will replace the old InventoryBar and SettingsBar as
part of the update for the SimpleClickGUI as proposed be Papernoise.
Players can now open the save, load, history and quit popups. They can
also change volumes, the text continue mode and the text speed.
…ent.

Now devs can set if the Sound Volumens component should show the Master
bus only and if it should show the label with the name for each bus.

- **upd** Add custom icons for radio buttons in PopupMenu for the
  base_gui_theme.tres.
This component uses a CheckButton with two labels so players can have
a better understanding of the current dialogue advancement mode.
This also updates the behavior of the cursor when hovering the settings
button (to be improved).
The script is executed only if the project is using the SimpleClick
template, and it removes the InventoryBar, SettingsBar,
TextSettingsPopup and SoundSettingsPopup components.
…he SaveAndLoadPopup.

The new Simple Click GUI uses the SimpleClickBar and the
SimpleClickPopup components. Instead of adding a new migration step, the
SaveAndLoadPopup is also removed in the first step and then added in the
second one.

- **upd** Remove the `@onready` vars in the Simple Click GUI to access
  the SaveAndLoadPopup, HistoryPopup, and QuitPopup since it is no
  longer used to open those popups.
@mapedorr mapedorr force-pushed the feature/373-simple-click-gui-improvements branch from d5029c9 to 49c4e3a Compare January 17, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant