Skip to content

Commit

Permalink
feat(gha): poe runs ruff and mypy with command lint now
Browse files Browse the repository at this point in the history
  • Loading branch information
aleneum committed Feb 6, 2025
1 parent 840d05c commit 57cf485
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/python-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ jobs:
python-version: "3.12"
- name: Install development dependencies with extras
run: uv sync
- name: Run ruff linting via pre-commit on all files and verbose
uses: pre-commit/[email protected]
with:
extra_args: ruff --all-files -v
- name: Run linting
run: uv run poe lint
testing:
Expand Down Expand Up @@ -53,4 +49,4 @@ jobs:
- name: Run Tests
run: uv run poe cov
- name: Report Coverage
run: uv run coverage report --skip-covered --omit="tests/*" --format=markdown >> $GITHUB_STEP_SUMMARY
run: uv run coverage report --skip-covered --omit="tests/*" --format=markdown >> $GITHUB_STEP_SUMMARY
8 changes: 5 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,10 @@ llama-cpp-python = [

[tool.poe.tasks]
test = "pytest -x"
cov = "coverage run -m pytest -x"
lint = "mypy gerd"
cov = "coverage run --source=gerd -m pytest -x"
lint_ruff = "uv run pre-commit run ruff --all-files"
lint_mypy = "mypy gerd"
lint = ["lint_ruff", "lint_mypy"]
qa_dev = "gradio gerd/frontends/qa_frontend.py"
gen_dev = "gradio gerd/frontends/gen_frontend.py"
router_dev = "gradio gerd/frontends/router.py"
Expand Down Expand Up @@ -101,7 +103,7 @@ select = [
"ARG", # no unused arguments
"PERF", # performance anti pattern
# "FURB", # enforces modern python
# "D", # enforce documented functions [will be enabled soon]
# "D", # enforce documented functions
]

# 2. Fix everything except flake8-bugbear (`B`) violations.
Expand Down

0 comments on commit 57cf485

Please sign in to comment.