Fix: Load system-wide native cert on rustls

[NobodyXu]

Related: nabijaczleweli/cargo-update#250

[NobodyXu]

@arvid-norlander This PR might fix the issue you experienced.

It now enables reqwest/rustls-tls-native-certs feature, which now checks system-wide cert:

    [
        "/var/ssl",
        "/usr/share/ssl",
        "/usr/local/ssl",
        "/usr/local/openssl",
        "/usr/local/etc/openssl",
        "/usr/local/share",
        "/usr/lib/ssl",
        "/usr/ssl",
        "/etc/openssl",
        "/etc/pki/ca-trust/extracted/pem",
        "/etc/pki/tls",
        "/etc/ssl",
        "/etc/certs",
        "/opt/etc/ssl", // Entware
        "/data/data/com.termux/files/usr/etc/tls",
        "/boot/system/data/ssl",
    ]

And also checks environment variables:

/// The OpenSSL environment variable to configure what certificate file to use.
pub const ENV_CERT_FILE: &'static str = "SSL_CERT_FILE";

/// The OpenSSL environment variable to configure what certificates directory to use.
pub const ENV_CERT_DIR: &'static str = "SSL_CERT_DIR";

While it still doesn't seem to check the /etc/ca-certificates, it at least load a few others and support env, so it might solve your issue.

If it doesn't, I will add reading from /etc/ca-certificates in cargo-binstall in a separate PR.

[NobodyXu]

Oh it should fix the issue for you - /etc/ca-certificates.conf merely lists the certs you wished to install to /etc/ssl/certs and /etc/ca-certificates is a dir containing updating scripts.

Since rustls-tls-native-certs includes /etc/ssl it should fix the issue for you.

@arvid-norlander can you try this PR locally please?

[passcod]

wasn't aware you could set both those features, good to know

[arvid-norlander]

Hi, today I'm at the office (behind the corporate proxy) so I gave this a try (even though you merged it already?).

It seems to work from a brief test (cargo run --bin=cargo-binstall -- cargo-binstall was able to install binstall itself successfully, while the latest release of cargo-binstall is unable to do the same).

[NobodyXu]

@arvid-norlander Thank you, I will cut a new release this Sunday.

P.S. regarding the merge before testing, I was confident that this PR would fix many use cases of binstall, so I would like to merge it.

Has it turned out not working, I will continue investigating and create another PR at fixing the issue.