Fix installer downloads for specific releases #1976
Conversation
Heads-up, I added a second commit that ensures that the install script is tested with and without the |
mjpieters
force-pushed
the
fix-install-script
branch
2 times, most recently
from
8111fa2 to
8ec2195
Compare
Github download urls for a specific release uses the pattern `../releases/download/[RELEASE]/..`, which differs from the latest release URL which uses `../releases/latest/download/..`. For convenience, if `BINSTALL_VERSION` is set but doesn't start with `v`, the v is prefixed.
mjpieters
force-pushed
the
fix-install-script
branch
2 times, most recently
from
3a55c3a to
8f30b72
Compare
|
Right, reasonably confident now that the workflow will now pass. |
.github/workflows/install-script.yml
Outdated
| - name: Set `BINSTALL_VERSION` | ||
| if: matrix.set_binstall_version != 'no' | ||
| env: | ||
| STRIP_V: ${{ matrix.set_cargo_home == 'with-v' && '1' || '' }} |
There was a problem hiding this comment.
This is not working as I intended it to.
The variable is empty regardless of the value of matrix.set_cargo_home. I'll have to do a bit of research.
There was a problem hiding this comment.
I've pushed an update; instead of fighting with Github Actions expression syntax, the matrix value is copied directly into the environment variable and the step then tests for without-v in bash to make the strip-or-not call.
@NobodyXu: All this means I need another workflow run approval. Sorry for the run-around on this.
There was a problem hiding this comment.
Thank you, it has been merged!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
When running the install-script workflow in Github Actions, add matrix options for not setting the variable, setting it to the latest release with the `v` prefix, and setting it to the latest release without the `v` prefix.
mjpieters
force-pushed
the
fix-install-script
branch
from
8f30b72 to
e460b2e
Compare
Github download urls for a specific release uses the pattern
../releases/download/[RELEASE]/.., which differs from the latest release URL which uses../releases/latest/download/...For convenience, if
BINSTALL_VERSIONis set but doesn't start withv, the v is prefixed.Fixes #1974