Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data cleaning with multiple platforms #182

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Meng6
Copy link
Collaborator

@Meng6 Meng6 commented Apr 29, 2022

Hi @JulioV, I created a branch named data_cleaning/multiple_platforms based on our discussion. Could you review the code when you are free? Thanks!

The following things are different from our conversation:

  • Besides timestamp and os columns, the device_id column was also added to platforms output. We need this column to run readable_datetime.R script. By doing so, we can use the correct timezone to get local_datetime. (not UTC)
  • While running readable_datetime.R script to convert timestamp to local_date_time, I set device_type to phone_platforms, which can skip the step of filter_wanted_dates: the start_date and end_date will be NA.
  • For data cleaning script, I do not assign the majority class of the platforms. Instead, I assume all the time segments with multiple platforms to be iOS platform. The reason is that all the iOS features can also be extracted from Android devices. But, some Android features are not available for iOS devices. Selected event features are imputed with 0 by the following two steps: (1) features which can be extracted from both Android and iOS devices: impute all rows directly; (2) features which can only be extracted from Android devices: select these rows and impute

@Meng6 Meng6 requested a review from JulioV April 29, 2022 12:55
@JulioV
Copy link
Collaborator

JulioV commented Jun 28, 2022

I need to review this PR more carefully, I think we can make some optimizations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants