Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted BB when doors are oppened. #7133

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Conversation

JoseM98
Copy link
Contributor

@JoseM98 JoseM98 commented Feb 8, 2024

Description

Added a method to calculate and combine the BoundingBoxes of the vehicle with their BoundingBox. Modified GetVehicleBoundingBox to add the previous method.
Included AdjustVehicleBounds that calls to GetVehicleBoundingBox when the doors open or closes, CloseDoorPhys and OpenDoorPhys.
Fixed an issue in the ApplyTransformToBB method where the rotation of the BoundingBox is not handled.
Added Getters in the CarlaWheeledVehicle.h for getting ConstraintsComponents and ConstraintDoor.

Fixes #

Where has this been tested?

  • Platform(s): Windows 11
  • Python version(s): 3.8.10
  • Unreal Engine version(s): 4.26

Possible Drawbacks


This change is Reviewable

@JoseM98 JoseM98 requested a review from a team as a code owner February 8, 2024 09:27
Blyron
Blyron previously approved these changes Feb 8, 2024
Blyron
Blyron previously approved these changes Feb 14, 2024
@AreopagX
Copy link
Contributor

AreopagX commented Mar 21, 2024

@JoseM98 I tested your pr but it doesn't work for me. Can you share a demo script to reproduce the behavior?

EDIT:
I did some more testing. The bounding boxes can be retrieved using the world.get_level_bbs() function in Python code. Though, when accessing an actors bounding box using actor.bounding_box this does not work, as the cached actor dimensions are used. This can be fixed by making bounding_box attribute call a function that retrieves the bounding box from the server.
Furthermore, the autopilot still ignores vehicles with open doors since the bounding box dimensions are kept in a static data structure within SimulationState::static_attribute_map. I don't know a valid fix for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants