Typing and modernisation of Agent code #8072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: glopezdiest <[email protected]>
* Fix OSM2ODR build * Updated fix wheelchair default value
* fixed IMU units * updated autitwheel version
Daraan
commented
Aug 23, 2024
| @@ -15,7 +15,7 @@ | |||
| from agents.navigation.local_planner import RoadOption | |||
| from agents.navigation.behavior_types import Cautious, Aggressive, Normal | |||
|
|
|||
| from agents.tools.misc import get_speed, positive, is_within_distance, compute_distance | |||
There was a problem hiding this comment.
functions were unused
To enable auto-completion and hints in code editors such as VScode, create a `*.pyi` file. This feature is compatible with `python 3.9` and later versions.
Can be None or an Actor
needs merge with dev version
Syntax fix (squased)
FutureActor laod_world_if_different
Was changed to a function in 0.9.15. More info see: carla-simulator#7439
parameter is called in_point not in_vector
more setters missing, wrong types corrected spelling
Daraan
force-pushed
the
agent-modernisation
branch
from
481055b to
a693fa8
Compare
Daraan
force-pushed
the
agent-modernisation
branch
from
a693fa8 to
9879cbd
Compare
Removed empty variables and whitespaces formatting
Daraan
force-pushed
the
agent-modernisation
branch
from
f6bb133 to
bb2566d
Compare
The slowdown is considerably more noticeable here since the engine runs much smoother. This makes evident that this is a stopgap measure, and should be looked into further down the line.
…adplugins" (carla-simulator#8167) The downloadplugins target is already defined below (line 162).
|
@Daraan can you point to target ue4-dev? |
Yes and done. |
Blyron
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds:
TYPE_CHECKINGgranting good type coverage for pyright: basicVector3Dmethods that came in 0.9.13, e.g. location.this deprecates
agents.tools.misc compute_distance and vector.Compatibility is granted with some slight improvements in performance by using a global constant for the
epsvalue.Where has this been tested?
Possible Drawbacks
location.distance(location2)in favor of calculating the distance overnumpy, the results arenp.closebut not identical. I do not see an issue here.class BasicAgent(object): -> class BasicAgent:which results in slightly different type behavior in Python 2 only.This change is