Upgraded RSS example code #8123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
e.g. list comprehension where necessary
Daraan
force-pushed
the
rss-upgrade-I
branch
from
0722495 to
5d6e7a3
Compare
|
Thanks for the PR! Reviewed and looks ok. Please move to ue4-dev branch as destination branch before we merge it. |
|
Thanks you very for reviewing. I duplicated the rebased PR in #8596 to keep it easier to review in this PR. |
|
Closing in favor of #8596 since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed color coding to be like it was intended: One dynamic color value was unused and overwritten with a static one, others shared a variable and was jointly modified.
More efficient and simpler code.
Changed
np.matrixto np.array code.Note for reviewing:
np.matrixis always two dimensional even with operations that create different shapes fornp.arrayhence the swap fromnp.concatenatetostack.Where has this been tested?
Possible Drawbacks
This change is