Correct "libcarla.command" namespace and allow from carla.command import ...
#8161
+7
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6414
Currently
import carla.command
orfrom carla.command import ...
is not possible.This will raise:
This is because the
command
module is registered aslibcarla.command
insys.modules
. This is not really correct.This PR adjusts this:
carla.libcarla.command
carla.command
that can be imported.Note / Up to discussion:
This PR deletes
command.py
as otherwisecarla.command is not carla.libcarla.command
. Both modules would be equivalent but not the same. I think this is the cleaner option.Alternatives
This PR:
command
intolibcarla
we could put it intocarla
directly without creating a duplicatecarla.libcarla.command
.sys.modules
.libcarla
import carla.command
and onlyfrom carla import command
sys.modules
Where has this been tested?
This change is