-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting several additional OpenScenario 1.0 tags #1014
Supporting several additional OpenScenario 1.0 tags #1014
Conversation
fix bug of add new tags
@germanros1987 @glopezdiest We have re-created the PR for openscenario 1.0 new tags support, please ignore previous one #987 |
Is there any feedback? @germanros1987 |
@joel-mb can you review this, please? |
@synkrotron Hey, I tried it and seems like there is some issue with waypoint based scenarios. Do you tried with waypoint based scenarios also? |
Hello, do you have an example? |
Hey, I just posted this in https://github.com/guardstrikelab/scenario_runner as an issue. |
Hey @synkrotron, could you please resolve the conflicts so that we can merge the PR? |
Hi, @germanros1987, I resolved the code conflict by deleting the original branch 'feature/new_tags_support' and creating a new one (also named 'feature/new_tags_support') based on the master branch. However, it appears that this Pull Request has not been updated. Should I close this PR and create a new one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 11 files at r1, 1 of 5 files at r2, 3 of 5 files at r3, 6 of 6 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @joel-mb)
That's okay, there are no more conflicts, so we can merge the PR |
Description
We've added some new tags that weren't supported before, as shown in Changelog.md and openscenario_support.md.
Where has this been tested?
Possible Drawbacks
We did complete tests and found no errors.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)