Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting several additional OpenScenario 1.0 tags #1014

Merged

Conversation

synkrotron
Copy link
Contributor

@synkrotron synkrotron commented Aug 13, 2023

Description

We've added some new tags that weren't supported before, as shown in Changelog.md and openscenario_support.md.

Where has this been tested?

  • **Platform(s): ** ubuntu 20.04
  • Python version(s): python 3.8.10
  • Unreal Engine version(s): UE4
  • CARLA version: 0.9.13

Possible Drawbacks

We did complete tests and found no errors.


This change is Reviewable

@synkrotron
Copy link
Contributor Author

synkrotron commented Aug 13, 2023

@germanros1987 @glopezdiest We have re-created the PR for openscenario 1.0 new tags support, please ignore previous one #987

@charles-lei
Copy link
Contributor

Is there any feedback? @germanros1987

@germanros1987 germanros1987 requested a review from joel-mb August 24, 2023 01:05
@germanros1987
Copy link
Member

@joel-mb can you review this, please?

@ronyshaji
Copy link

@synkrotron Hey, I tried it and seems like there is some issue with waypoint based scenarios. Do you tried with waypoint based scenarios also?

@synkrotron
Copy link
Contributor Author

@synkrotron Hey, I tried it and seems like there is some issue with waypoint based scenarios. Do you tried with waypoint based scenarios also?

Hello, do you have an example?

@ronyshaji
Copy link

@synkrotron Hey, I tried it and seems like there is some issue with waypoint based scenarios. Do you tried with waypoint based scenarios also?

Hello, do you have an example?

Hey, I just posted this in https://github.com/guardstrikelab/scenario_runner as an issue.

@glopezdiest
Copy link
Contributor

Hey @synkrotron, could you please resolve the conflicts so that we can merge the PR?

@charles-lei charles-lei deleted the feature/new_tags_support branch September 9, 2023 03:59
@synkrotron
Copy link
Contributor Author

Hi, @germanros1987, I resolved the code conflict by deleting the original branch 'feature/new_tags_support' and creating a new one (also named 'feature/new_tags_support') based on the master branch. However, it appears that this Pull Request has not been updated. Should I close this PR and create a new one?

Copy link
Contributor

@glopezdiest glopezdiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 11 files at r1, 1 of 5 files at r2, 3 of 5 files at r3, 6 of 6 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @joel-mb)

@glopezdiest
Copy link
Contributor

That's okay, there are no more conflicts, so we can merge the PR

@glopezdiest glopezdiest merged commit 70426c1 into carla-simulator:master Sep 12, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants