Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for parsing parameters with scientific notation for OpenSCENARI… #1023

Merged
merged 2 commits into from
May 3, 2024

Conversation

golnazraja
Copy link
Contributor

@golnazraja golnazraja commented Sep 7, 2023

Description

Line number 105 in openscenario_parser.py has been changed.
This change will add support of parsing parameters with scientific notation for OpenSCENARIO files.

Fixes #927

Where has this been tested?

  • Platform(s): Ubuntu 20.04
  • Python version(s): 3.8.10
  • Unreal Engine version(s): 4.26
  • CARLA version: 0.9.13

This change is Reviewable

@fabianoboril
Copy link
Collaborator

Can you please rebase your commits. Thank you.

@golnazraja
Copy link
Contributor Author

Can you please rebase your commits. Thank you.

yes, I rebased my commits.

@haabe
Copy link
Contributor

haabe commented Nov 30, 2023

I believe this is fixed with this merge

@glopezdiest
Copy link
Contributor

Approved, but a couple of comments about the pattern.
First of all, while the one added by @haabe already implemented the scientific notation, this only worked for lower case e.
Secondly, this pattern does not accept any symbols between the number and the e / E (which is the example provided by the issue #927.

In summary, the accepted types are, for example,

  • 17254
  • 3583E+6
  • 3583E-6
  • 476e+5
  • 476e-5

Copy link
Contributor

@glopezdiest glopezdiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @golnazraja)

@glopezdiest glopezdiest merged commit 40b38fc into carla-simulator:master May 3, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openscenario_parse.py don't supports parameter which is scientific notation (for example, 1.234+e+01)
4 participants