Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow improvements and code quality passing #1052

Conversation

jeroenlammersma
Copy link
Contributor

@jeroenlammersma jeroenlammersma commented Jan 30, 2024

Description

  • Corrected name of unit tests workflow to 'Unit Tests' (was 'Static Code Analysis')
  • Updated checkout actions to v3.
  • Made some small tweaks to ensure 'Check Code Quality with Pylint' job passes.

Where has this been tested?

  • Platform(s): 20.04
  • Python version(s): 3.8.10
  • Unreal Engine version(s): UE4
  • CARLA version: 0.9.15

This change is Reviewable

Copy link
Contributor

@glopezdiest glopezdiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jeroenlammersma)

@glopezdiest glopezdiest merged commit db40fb7 into carla-simulator:master Apr 26, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants