Backward compatible upgrade to fix deprecation warnings concerning LooseVersion and pkg_resources for Python3.8+ #1058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
distutils LooseVersion and pkg_resources are deprecated and not available in later python versions.
This introduces two commits fixing these deprecation for Python3.8+ while maintaining functionality for Python3.7 and before.
NOTE: Reverting the second commit removes the backward compatibility to Python3.7, as
importlib.metadata
is introduced in Python3.8.Fixes #
Where has this been tested?
Possible Drawbacks
The second commit bloats the code a bit and should be reverted when python3.7 should not be supported anymore removing pkg_resources entirely.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)