Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add misc type default blueprint #1064

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

starrye
Copy link
Contributor

@starrye starrye commented Mar 11, 2024

Description

When creating a MiscObject, srunner will set the default category tomisc, and carla will enter if this object does not exist in Carla, there is no default misc blueprint objectthis, and a 'misc key error' will be reported. So the default blueprint object corresponding to misc was added

Fixes #

Where has this been tested?

  • Platform(s): Ubuntu 22.04
  • Python version(s): 3.7
  • Unreal Engine version(s): UE4
  • CARLA version: 0.9.15

Possible Drawbacks


This change is Reviewable

@starrye
Copy link
Contributor Author

starrye commented Mar 15, 2024

@glopezdiest please review.

Copy link
Contributor Author

@starrye starrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @starrye)

@starrye
Copy link
Contributor Author

starrye commented Apr 15, 2024

@PabloVD please review

@PabloVD PabloVD self-assigned this Apr 19, 2024
Copy link
Contributor

@PabloVD PabloVD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @starrye)

@PabloVD
Copy link
Contributor

PabloVD commented Apr 19, 2024

We agree on that change and proceed to merge it. Thanks!

@PabloVD PabloVD merged commit 2c9ea92 into carla-simulator:master Apr 19, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants