Fixed handling of Weather in OSC #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianoboril
force-pushed
the
fix/weatherOsc
branch
from
bb5d6db
to
4cc5903
Compare
Fixed an issue introduced 3 commits before (#656)
fabianoboril
force-pushed
the
fix/weatherOsc
branch
from
4cc5903
to
c17849c
Compare
glopezdiest
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
All good from my side. All the weather changes I did are working. We can merge it when the branch is updated
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue introduced 3 commits before (#656)
This change is