Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 3 compatibility fixes #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmatora
Copy link

@dmatora dmatora commented Jul 18, 2016

Fixes #34

@carlescliment
Copy link
Owner

Sorry, it seems it's not backwards-compatible. The build is failing due to a syntax error.

@dmatora
Copy link
Author

dmatora commented Jul 21, 2016

I'm not aware of symfony3 fork of any bundle, which is symfony2 compatible.
That's why i didn't do changes in master branch.

I probably should have changed tests as well, but i just wanted to get functionality working and thought someone else might need it.

On FriendsOfSymfony/FOSMessageBundle#275 so far it took 3 people to get symfony3 up and running, and we don't even know if we are there yet

@carlescliment
Copy link
Owner

Okay, what about those suggestions:

  • First, instead of removing the CSRF protection, we could use form_start and form_end as explained in the official documentation
  • Second, in order to keep master stable, we could start a new symfony-3 branch and start working on there. That way, users of Symfony2 could still point to master while Symfony3 ones could point to that branch.

What do you think?

@carlescliment
Copy link
Owner

I've created the branch: https://github.com/carlescliment/calendar-bundle/tree/dev-symfony3

Could you please cancel this PR and reopen it towards that branch?

@dmatora
Copy link
Author

dmatora commented Jul 21, 2016

Yeah, moving to form_start form_end was my initial idea, but after playing with it for a few minutes, i've realized i don't know it deep enough

I can not create pull request of my symfony3 branch, which is 2.5.2 based, into yours, which is master based. And i can not rebase it on master because master doesn't work for me on both symfony2/3 (i've mentioned it on issue #30)

@ickbinhier
Copy link

@carlescliment this problem is a show-stopper for the migration to symfony 3.1. Can please you fixit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants