Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cell.py for the problem when data_format='channels_first' #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MissLikeWind
Copy link

@MissLikeWind MissLikeWind commented Mar 12, 2018

When the data_format is 'channels_first', there is a small problem. I solve it by modifying 'cell.py'.

@carlthome
Copy link
Owner

carlthome commented Mar 12, 2018

Thanks for fixing this! How does NCHW work with 1D (e.g. audio) and 4D convolutions (e.g. video)? https://www.tensorflow.org/api_docs/python/tf/nn/convolution

Could you add data_format='channels_last' to some examples in README.md just to be sure?

I modify it for 1D, 2D and 3D data when using channels_first format.
@MissLikeWind
Copy link
Author

MissLikeWind commented Mar 13, 2018

Sorry, NCHW can not work with 1D or 3D convolutions. I correct this file again.

@1995Emma
Copy link

My data is with shape of [50, 50, 50].I try to use the "bidirectional_dynamic_rnn" to deal with the indefinite length,and when the sequence_length is defined it shows that the reverse_op cannot handle the tensor with 6D. Is there any method to solve the bug?

@carlthome
Copy link
Owner

@1995Emma not sure, but perhaps this should be opened in a separate GitHub issue? Or is it related to @MissLikeWind's pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants