Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Apprise mailto:// and apprise.utils module #1255

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 15, 2024

Description:

Related issue (if applicable): n/a

  • Refactored apprise/utils.py into a cleaner submodule
  • Refactored mailto:// and extracted PGP (Pretty Good Privacy) into it's own reusable module.
  • mailto:// now has a static method that can be used to generate emails for other mailing services. To be used in GMail OAuth2 Support (gmail://) #1250

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@utils-mailto-refactor

@caronc caronc force-pushed the utils-mailto-refactor branch from d636552 to d3ed023 Compare December 15, 2024 17:44
@caronc caronc force-pushed the utils-mailto-refactor branch from d3ed023 to 9f561c8 Compare December 15, 2024 17:58
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 99.85185% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.36%. Comparing base (4d21759) to head (9f561c8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
apprise/utils/pgp.py 99.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
- Coverage   99.37%   99.36%   -0.01%     
==========================================
  Files         148      159      +11     
  Lines       20776    20687      -89     
  Branches     3709     3715       +6     
==========================================
- Hits        20646    20556      -90     
  Misses        121      121              
- Partials        9       10       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 551fa0d into master Dec 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant