Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with long episodes #455

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Deal with long episodes #455

merged 6 commits into from
Apr 29, 2024

Conversation

carschno
Copy link
Collaborator

  • Add an example schedule
  • Add reminders for instructor switches/breaks in episodes.

Fixes #446

@carschno carschno self-assigned this Apr 29, 2024
Copy link

github-actions bot commented Apr 29, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-455

The following changes were observed in the rendered markdown documents:

 1-introduction.md          |   6 ++
 2-keras.md                 |  11 +++
 3-monitor-the-model.md     |  10 +++
 4-advanced-layer-types.md  |   5 ++
 bonus-material.md (gone)   | 199 ---------------------------------------------
 design.md (gone)           | 120 ---------------------------
 index.md                   |  11 +++
 instructor-notes.md (gone) |  36 --------
 md5sum.txt                 |  17 ++--
 schedule.md (new)          |  41 ++++++++++
 survey-templates.md (gone) |  77 ------------------
 11 files changed, 91 insertions(+), 442 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-04-29 15:00:27 +0000

github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@carschno carschno marked this pull request as draft April 29, 2024 13:29
@carschno carschno marked this pull request as ready for review April 29, 2024 13:31
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@carschno carschno requested a review from svenvanderburg April 29, 2024 13:36
Copy link
Collaborator

@svenvanderburg svenvanderburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @carschno ! I added a few small suggestions, I hope you agree with them :) Feel free to merge after resolving the comments.

Comment on lines +249 to +253
::: instructor
## BREAK
This is a good time for switching instructor and/or a break.
:::

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think it makes sense to have the introduction be done by one instructor, and I think that's what we usually do in practice. Still if you have to break somewhere in the episode this is a good place.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, in my mind switching instructor aligns very well to having a break, although it is not necessary to have both.
In my understanding, these notes are mostly for orientation and details are up to the current instructors. Do you think it needs to be clarified more?

index.md Outdated Show resolved Hide resolved
index.md Outdated Show resolved Hide resolved
instructors/schedule.md Outdated Show resolved Hide resolved
carschno and others added 3 commits April 29, 2024 16:58
Co-authored-by: Sven van der Burg <[email protected]>
Co-authored-by: Sven van der Burg <[email protected]>
Co-authored-by: Sven van der Burg <[email protected]>
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@carschno carschno merged commit 32e9e4e into main Apr 29, 2024
3 checks passed
@carschno carschno deleted the deal_with_long_episodes branch April 29, 2024 15:17
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
Auto-generated via {sandpaper}
Source  : 32e9e4e
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-04-29 15:16:51 +0000
Message : Merge pull request #455 from carpentries-incubator/deal_with_long_episodes

Deal with long episodes
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
Auto-generated via {sandpaper}
Source  : 32e9e4e
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-04-29 15:16:51 +0000
Message : Merge pull request #455 from carpentries-incubator/deal_with_long_episodes

Deal with long episodes
carschno added a commit to carschno/intro-to-deep-learning-archaeology that referenced this pull request Apr 30, 2024
Auto-generated via {sandpaper}
Source  : 32e9e4e
Branch  : main
Author  : Carsten Schnober <[email protected]>
Time    : 2024-04-29 15:16:51 +0000
Message : Merge pull request carpentries-incubator#455 from carpentries-incubator/deal_with_long_episodes

Deal with long episodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deal with relatively long episodes in instructor notes
2 participants