Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carpentries review comments #183

Merged

Conversation

alanocallaghan
Copy link
Collaborator

@alanocallaghan alanocallaghan commented Dec 17, 2024

Per review in: carpentries-lab/reviews#19

  • Fix heading levels (remove h1s)
  • Improve table alt-text (ch1), pairsplot alt-text (ch4), heatmap alt-text (ch 7).
  • Add missing table header (ch2)
  • Remove slides, as these are likely to suffer substantial drift from lesson content and shouldn't be necessary :)
  • Add comment in instructor notes about managing cognitive load.

@alanocallaghan alanocallaghan changed the title Carp review comments Carpentries review comments Dec 23, 2024
@catavallejos
Copy link
Collaborator

Thanks for making all these changes @alanocallaghan . Looks good! And I agree that having the slides is redundant and risks having them non up-to-date.

@catavallejos catavallejos merged commit d88b308 into carpentries-incubator:main Dec 23, 2024
4 checks passed
@alanocallaghan alanocallaghan deleted the carp-review-comments branch December 23, 2024 10:07
@alanocallaghan
Copy link
Collaborator Author

Thanks! Will blitz the paper #175 early next year inshallah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants