Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Travis build #84

Open
wants to merge 6 commits into
base: gh-pages
Choose a base branch
from
Open

Fixing Travis build #84

wants to merge 6 commits into from

Conversation

vinisalazar
Copy link
Contributor

Hi,

This PR is an attempt to fix the Travis build process. Changes were originally being made in #80, but I decided to create a separate PR just for them (and revert them in the aforementioned PR).

Summary of changes:

  • Edit .travis.yml
  • Update Gemfile to match latest Carpentries lessons

If this is merged, hopefully future PRs won't fail the Travis build.

Best,
Vini

@vinisalazar
.travis.yml: attempting to fix Travis build.
77b786f
@vinisalazar
Gemfile: update Gemfile with latest Carpentries template.
8f4afb0 
  - This is mostly to prevent Travis build errors.
  - Discussed in carpentries-incubator#80.
@vinisalazar
.travis.yml: attempting to fix Travis build.
5e6dda3 
  - Removed the 'make lesson-check-all' command.
  - This command requires the '_includes/links.md', which is not present in the repository.
  - This is due to the remote theme being used, which dispenses the need of an '_includes/' directory.
  - Discussed in carpentries-incubator#80.
@vinisalazar
.travis.yml: attempting to fix Travis build.
778d28d 
  - Use correct version of Ruby.
  - Discussed in carpentries-incubator#80.
@vinisalazar vinisalazar mentioned this pull request May 26, 2021
Open
@vinisalazar
.travis.yml: attempting to fix Travis build.
c911995 
  - Revert previous commit (remove --always-make flag).
  - Add bundler to gem install command.
  - Discussed in carpentries-incubator#80.
@vinisalazar
Makefile: update JEKYLL variable.
c208888 
  - Match the Makefile from the Python Inflammation lesson.
  - Discussed in carpentries-incubator#84.
@vinisalazar
Copy link
Contributor Author

vinisalazar commented May 27, 2021 •
edited
Loading

I updated the Makefile by matching the JEKYLL variable to the same command as the Python Inflammation lesson (that was building correctly). This seemed to allow the build complete.

I would further suggest removing the R dependencies in the .travis.yml config, as they don't seem necessary and not having them would probably make the build faster.

@brownsarahm brownsarahm requested a review from fmichonneau May 27, 2021 21:42
@brownsarahm
Copy link
Collaborator

I tagged in @fmichonneau because this file isn't a part of the lesson itself.

@vinisalazar
Copy link
Contributor Author

vinisalazar commented May 28, 2021 •
edited
Loading

As a side note: I did notice similar problems in other Carpentries repositories, e.g. this PR in the Python Ecology Lesson and this commit in the Inflammation lesson. In the former one, the build fails upon trying to install R dependencies (fixed by 77b786f in this PR), and in the latter, all tests pass, except the Travis build.

@vinisalazar vinisalazar mentioned this pull request May 31, 2021
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmichonneau fmichonneau Awaiting requested review from fmichonneau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinisalazar @brownsarahm