-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 3 working with raster data #3
Conversation
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. Results of any additional workflows will appear here when they are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider my comments to improve this lessons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello. This lesson is still quite long and a bit abstract. I think it might help to skip a few operations and instead give some context on why we might want to subtract raster or what to do with the result (in the context of urban and social research and practice)
Co-authored-by: Daniele Cannatella <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of Episode 13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review episode 15 done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
episode 15 reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
episode 17 reviewed
Co-authored-by: Daniele Cannatella <[email protected]>
Co-authored-by: Daniele Cannatella <[email protected]>
Co-authored-by: Daniele Cannatella <[email protected]>
I shortened the lesson as followed:
|
Thanks all for the input. This lesson is ready to be merged into main. |
This will be stored in a different place and made available to participants via a download link
Thanks @manuGil for taking the time to improve this image! It is clearer, but the issue is that the terrain is still kept in the CHM. The subtraction should lead to a 'flat' ground so that only the height of trees and buildings is visible. Let's keep the original illustration for now. I will open an issue in the main repo for us to remember to update the figure after our upcoming workshop. |
I migrated the content of the third part to the workbench format.
Things left to do:
Main changes made in the lesson:
raster
package withterra
. This way we only use one consistent package that integrates the functionality ofraster
andrgdal
used in the previous version of the workshop.Please ignore the vector episodes and only review the raster episodes in this PR. Vector episodes are in the separate PR #1.
To review this PR locally, follow these steps:
New Project... > Version Control
, using the urlhttps://github.com/carpentries-incubator/r-geospatial-urban.git
.git fetch origin pull/3/head:claudiu-raster
. This will create a new local branch with the nameclaudiu-raster
that contains the code from Part 3 working with raster data #3.git switch claudiu-raster
to move to the newly created branch. Make sure your project is read-only, that is, you do not make changes to any of the files in your project; otherwise, git will not allow you to move to another branch.episodes\
folder and examine the output in the rendered website. Please use this local copy as read-only and do not push changes from it. Instead, comment and suggest changes via the GitHub reviewing interface.