Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 3 working with raster data #3

Merged
merged 39 commits into from
Jan 29, 2024

Conversation

cforgaci
Copy link
Collaborator

@cforgaci cforgaci commented Oct 30, 2023

I migrated the content of the third part to the workbench format.

Things left to do:

  • Add lessons to workbench template
  • Revise lesson content based on feedback from the last workshop
  • Adjust time needed to teach and for challenges according to changes in content

Main changes made in the lesson:

  • Replaced raster package with terra. This way we only use one consistent package that integrates the functionality of raster and rgdal used in the previous version of the workshop.

Please ignore the vector episodes and only review the raster episodes in this PR. Vector episodes are in the separate PR #1.

To review this PR locally, follow these steps:

  1. If you have a clone of this repository on your computer in an RStudio project, skip this step. Otherwise, clone it to your computer in RStudio via New Project... > Version Control, using the url https://github.com/carpentries-incubator/r-geospatial-urban.git.
  2. If you've already installed the packages below in RStudio, skip this step. Otherwise, run the following code in your console to install them:
install.packages(c("sandpaper", "varnish", "pegboard", "tinkr"),
  repos = c("https://carpentries.r-universe.dev/", getOption("repos")))
  1. In your RStudio project, open the terminal and run git fetch origin pull/3/head:claudiu-raster. This will create a new local branch with the name claudiu-raster that contains the code from Part 3 working with raster data #3.
  2. Still in the terminal/command line, run git switch claudiu-raster to move to the newly created branch. Make sure your project is read-only, that is, you do not make changes to any of the files in your project; otherwise, git will not allow you to move to another branch.
  3. In RStudio build the workshop website with Ctrl + Shift + B (Windows) or Command + Shift + B (Mac)
  4. To review, read and run the code in the Rmd files found in the episodes\ folder and examine the output in the rendered website. Please use this local copy as read-only and do not push changes from it. Instead, comment and suggest changes via the GitHub reviewing interface.

@github-actions
Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files or spoofing.

Results of any additional workflows will appear here when they are done.

@cforgaci cforgaci self-assigned this Oct 31, 2023
@cforgaci cforgaci marked this pull request as ready for review October 31, 2023 09:15
@cforgaci cforgaci requested review from alwil, ClementineCttn, fcjerome, manuGil, Selkubi and KyriJanssen and removed request for alwil October 31, 2023 09:15
Copy link
Collaborator

@manuGil manuGil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my comments to improve this lessons.

episodes/13-intro-to-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/13-intro-to-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/13-intro-to-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/13-intro-to-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/14-plot-raster-data.Rmd Show resolved Hide resolved
episodes/14-plot-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/14-plot-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/14-plot-raster-data.Rmd Show resolved Hide resolved
episodes/16-raster-calculations.Rmd Show resolved Hide resolved
episodes/16-raster-calculations.Rmd Show resolved Hide resolved
Copy link
Collaborator

@ClementineCttn ClementineCttn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. This lesson is still quite long and a bit abstract. I think it might help to skip a few operations and instead give some context on why we might want to subtract raster or what to do with the result (in the context of urban and social research and practice)

episodes/13-intro-to-raster-data.Rmd Show resolved Hide resolved
episodes/14-plot-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/14-plot-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/14-plot-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/16-raster-calculations.Rmd Show resolved Hide resolved
episodes/13-intro-to-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/13-intro-to-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/13-intro-to-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/13-intro-to-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/14-plot-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/16-raster-calculations.Rmd Outdated Show resolved Hide resolved
episodes/16-raster-calculations.Rmd Show resolved Hide resolved
episodes/16-raster-calculations.Rmd Show resolved Hide resolved
episodes/16-raster-calculations.Rmd Outdated Show resolved Hide resolved
episodes/16-raster-calculations.Rmd Show resolved Hide resolved
Co-authored-by: Daniele Cannatella <[email protected]>
Copy link
Collaborator

@dcannatella dcannatella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of Episode 13

episodes/13-intro-to-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/13-intro-to-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/13-intro-to-raster-data.Rmd Outdated Show resolved Hide resolved
Copy link
Collaborator

@dcannatella dcannatella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review episode 15 done

episodes/14-plot-raster-data.Rmd Outdated Show resolved Hide resolved
Copy link
Collaborator

@dcannatella dcannatella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

episode 15 reviewed

episodes/15-reproject-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/15-reproject-raster-data.Rmd Show resolved Hide resolved
episodes/15-reproject-raster-data.Rmd Outdated Show resolved Hide resolved
episodes/15-reproject-raster-data.Rmd Outdated Show resolved Hide resolved
Copy link
Collaborator

@dcannatella dcannatella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

episode 17 reviewed

episodes/17-work-with-multi-band-rasters.Rmd Outdated Show resolved Hide resolved
episodes/17-work-with-multi-band-rasters.Rmd Outdated Show resolved Hide resolved
@cforgaci
Copy link
Collaborator Author

Hi, @ClementineCttn. Thanks for the comments.

Hello. This lesson is still quite long and a bit abstract. I think it might help to skip a few operations

  • Drop a few operations to shorten raster lesson

I shortened the lesson as followed:

  • removed the hillshade part entirely
  • removed one challenge
  • simplified a couple of challenges
  • removed the mention and figure of CHM in episode 15

@cforgaci
Copy link
Collaborator Author

Thanks all for the input. This lesson is ready to be merged into main.

@manuGil
Copy link
Collaborator

manuGil commented Jan 26, 2024

I made a figure illustrating the digital height canopy model. I thinks this illustrates it in a slightly better way. What do you think? How can I improve on it?

chm

@cforgaci
Copy link
Collaborator Author

Hello. This lesson is still quite long and a bit abstract. I think it might help to skip a few operations and instead give some context on why we might want to subtract raster or what to do with the result (in the context of urban and social research and practice)

Thanks @manuGil for taking the time to improve this image! It is clearer, but the issue is that the terrain is still kept in the CHM. The subtraction should lead to a 'flat' ground so that only the height of trees and buildings is visible.

Let's keep the original illustration for now. I will open an issue in the main repo for us to remember to update the figure after our upcoming workshop.

@cforgaci cforgaci mentioned this pull request Jan 29, 2024
@cforgaci cforgaci merged commit da5cef0 into carpentries-incubator:main Jan 29, 2024
2 of 3 checks passed
@cforgaci cforgaci deleted the 3-raster-cf branch January 29, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants