Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tydeverse coding style on Lessons 1 - 12 #30

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Conversation

manuGil
Copy link
Collaborator

@manuGil manuGil commented Feb 18, 2024

This PR formats code blocks using the STYLER addin, and the Tidy-verse codding guidelines. Affects lesson files 1 to 12.

Response to #28

@manuGil manuGil added the type:formatting Formatting needs to be fixed label Feb 18, 2024
@manuGil manuGil requested a review from cforgaci February 18, 2024 14:20
Copy link

github-actions bot commented Feb 18, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/r-geospatial-urban/compare/md-outputs..md-outputs-PR-30

The following changes were observed in the rendered markdown documents:

 01-intro-to-r.md                                  |  26 +--
 02-data-structures.md                             |  34 ++--
 03-explore-data.md                                |  42 ++---
 04-intro-to-visualisation.md                      | 143 +++++++-------
 09-open-and-plot-vector-layers.md                 |   2 +-
 10-explore-and-plot-by-vector-layer-attributes.md | 114 +++++++-----
 11-plot-multiple-shape-files.md                   | 216 ++++++++++++----------
 12-handling-spatial-projection-and-crs.md         |  93 +++++-----
 18-import-and-visualise-osm-data.md               |   4 +-
 md5sum.txt                                        |  16 +-
 10 files changed, 377 insertions(+), 313 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-02-18 14:26:37 +0000

github-actions bot pushed a commit that referenced this pull request Feb 18, 2024
Copy link
Collaborator

@cforgaci cforgaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @manuGil for this. It looks all good.

@cforgaci cforgaci merged commit 0b0b7aa into main Apr 10, 2024
3 checks passed
@cforgaci cforgaci deleted the manuel/codestyle branch April 10, 2024 09:32
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
Auto-generated via {sandpaper}
Source  : 0b0b7aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-04-10 09:32:53 +0000
Message : Merge pull request #30 from carpentries-incubator/manuel/codestyle

Implement Tydeverse coding style on Lessons 1 - 12
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
Auto-generated via {sandpaper}
Source  : 199823a
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-04-10 09:38:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 0b0b7aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-04-10 09:32:53 +0000
Message : Merge pull request #30 from carpentries-incubator/manuel/codestyle

Implement Tydeverse coding style on Lessons 1 - 12
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
Auto-generated via {sandpaper}
Source  : 0b0b7aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-04-10 09:32:53 +0000
Message : Merge pull request #30 from carpentries-incubator/manuel/codestyle

Implement Tydeverse coding style on Lessons 1 - 12
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
Auto-generated via {sandpaper}
Source  : e949443
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-04-16 00:38:21 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 0b0b7aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-04-10 09:32:53 +0000
Message : Merge pull request #30 from carpentries-incubator/manuel/codestyle

Implement Tydeverse coding style on Lessons 1 - 12
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
Auto-generated via {sandpaper}
Source  : 0b0b7aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-04-10 09:32:53 +0000
Message : Merge pull request #30 from carpentries-incubator/manuel/codestyle

Implement Tydeverse coding style on Lessons 1 - 12
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
Auto-generated via {sandpaper}
Source  : 4656078
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-04-23 00:39:27 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 0b0b7aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-04-10 09:32:53 +0000
Message : Merge pull request #30 from carpentries-incubator/manuel/codestyle

Implement Tydeverse coding style on Lessons 1 - 12
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
Auto-generated via {sandpaper}
Source  : 0b0b7aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-04-10 09:32:53 +0000
Message : Merge pull request #30 from carpentries-incubator/manuel/codestyle

Implement Tydeverse coding style on Lessons 1 - 12
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
Auto-generated via {sandpaper}
Source  : a5b8196
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-04-30 00:37:41 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 0b0b7aa
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-04-10 09:32:53 +0000
Message : Merge pull request #30 from carpentries-incubator/manuel/codestyle

Implement Tydeverse coding style on Lessons 1 - 12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:formatting Formatting needs to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants