-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup test workflow for various OSs #40
Conversation
ℹ️ Modified WorkflowsThis pull request contains modified workflow files and no preview will be created. Workflow files modified:
If this is not from a trusted source, please inspect the changes for any malicious content. |
Thanks @manuGil and @Selkubi for starting to work on this! I did not have time to look into this yet, but I would start assembling the configuration for this by looking at r-lib/actions and the workflows used by our repository. |
I added the installations steps from the lessons. However, the windows job keeps failing The windows job fails because of the R version (strange enough, it worked the very first time). The job fails in step: Run r-lib/actions/setup-r@v2
D:\a\_temp\R-4.3.3-win.exe /VERYSILENT /SUPPRESSMSGBOXES /DIR=C:\R
Downloading https://cran.rstudio.com/bin/windows/Rtools/Rtools4.3.x.exe...
Error: Failed to get R 4.3.3: Failed to get R 4.3.3: Failed to download version [object Object]: Error: Unexpected HTTP response: 404 |
@manuGil, nice! That is a 404 response, so the link does not seem to be correct. Does this work instead? https://cran.r-project.org/bin/windows/Rtools/rtools43/files/rtools43-5958-5975.exe |
@cforgaci The link is being provided by an action from https://github.com/r-lib/actions/tree/v2-branch/setup-r The only part that I changed was the R version the workflow uses. So I guess is an issue with their action because it works for the other OSs... Or it could be that for windows it is different. Maybe the following can give us an insight on what the problem is:
|
@manuGil I have tried in my fork
|
Also, when I directly copy the matrix testing and change the R version the test runs smoothly and when I add the os |
I fixed the issue with Windows. The name for the version of RTools was wrongly written (it should be The issue with MacOS is partially solved. I made progress with most of the errors with Trace back: https://github.com/manuGil/r-geospatial-urban/actions/runs/8401072439/job/23009071352 |
Somona is now available for runners as latest version for MacOS |
Check if installing XCode solves this issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @manuGil for this! I suggested an R script to test sf and tidyverse in my last comment.
sudo apt-get update | ||
sudo apt-get install libgdal-dev libgeos-dev libproj-dev -y | ||
shell: bash | ||
# Include Fedora and Arch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I would add those too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I will add those in the next revision. I opened this issue #45 for that. For now, I suggest we complete the merge for the current tests.
Co-authored-by: Claudiu Forgaci <[email protected]>
Excellent. Thanks, @manuGil! I will merge the PR. |
Auto-generated via {sandpaper} Source : 60bd8aa Branch : main Author : Claudiu Forgaci <[email protected]> Time : 2024-05-02 18:37:44 +0000 Message : Merge pull request #40 from manuGil/main
Auto-generated via {sandpaper} Source : 1cd1252 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-05-02 18:43:23 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 60bd8aa Branch : main Author : Claudiu Forgaci <[email protected]> Time : 2024-05-02 18:37:44 +0000 Message : Merge pull request #40 from manuGil/main
Auto-generated via {sandpaper} Source : 60bd8aa Branch : main Author : Claudiu Forgaci <[email protected]> Time : 2024-05-02 18:37:44 +0000 Message : Merge pull request #40 from manuGil/main
Auto-generated via {sandpaper} Source : c686ae1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-05-07 00:42:16 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 60bd8aa Branch : main Author : Claudiu Forgaci <[email protected]> Time : 2024-05-02 18:37:44 +0000 Message : Merge pull request #40 from manuGil/main
Auto-generated via {sandpaper} Source : 60bd8aa Branch : main Author : Claudiu Forgaci <[email protected]> Time : 2024-05-02 18:37:44 +0000 Message : Merge pull request #40 from manuGil/main
Auto-generated via {sandpaper} Source : b47841e Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-05-14 00:39:39 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 60bd8aa Branch : main Author : Claudiu Forgaci <[email protected]> Time : 2024-05-02 18:37:44 +0000 Message : Merge pull request #40 from manuGil/main
This is an initial workflow for testing the installation instructions in various Os. Later today we will continue with #33