Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated draft for setup instructions #48

Merged
merged 3 commits into from
May 20, 2024
Merged

updated draft for setup instructions #48

merged 3 commits into from
May 20, 2024

Conversation

Selkubi
Copy link
Collaborator

@Selkubi Selkubi commented May 8, 2024 •
edited
Loading

Completed the 1st draft of the setup instructions according to the issue #33 . Should cover most of the 1st and 2nd items. Keeping it as a draft pull assuming we'll do some iterations on it.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files or spoofing.

Results of any additional workflows will appear here when they are done.

github-actions bot pushed a commit that referenced this pull request May 8, 2024
@actions-user
differences for PR #48
72f2a72
cforgaci
cforgaci reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@cforgaci cforgaci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Selkubi for drafting this! I left some comments and suggestions. Feel free to process and commit them.

learners/setup.md Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
@cforgaci cforgaci marked this pull request as ready for review May 16, 2024 10:13
@cforgaci cforgaci linked an issue May 16, 2024 that may be closed by this pull request
Update setup instructions #33
Closed
4 tasks
@cforgaci cforgaci changed the title updated draft for setup instructions following issue #33 updated draft for setup instructions May 16, 2024
github-actions bot pushed a commit that referenced this pull request May 17, 2024
@actions-user
differences for PR #48
907a24c
cforgaci
cforgaci reviewed May 20, 2024
View reviewed changes
Copy link
Collaborator

@cforgaci cforgaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with R version 4.4.0

learners/setup.md Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
learners/setup.md Outdated Show resolved Hide resolved
cforgaci
cforgaci approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@cforgaci cforgaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Selkubi! This can be merged.

@cforgaci cforgaci merged commit e9373d7 into carpentries-incubator:main May 20, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request May 20, 2024
@actions-user
markdown source builds
50b768e 
Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request May 20, 2024
@actions-user
site deploy
fc2b191 
Auto-generated via {sandpaper}
Source  : 50b768e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-20 16:23:35 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request May 21, 2024
@actions-user
markdown source builds
c424859 
Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request May 21, 2024
@actions-user
site deploy
6377c11 
Auto-generated via {sandpaper}
Source  : c424859
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-21 00:40:06 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request May 28, 2024
@actions-user
markdown source builds
39e5e3b 
Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request May 28, 2024
@actions-user
site deploy
d939a2d 
Auto-generated via {sandpaper}
Source  : 39e5e3b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-28 00:40:21 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
@actions-user
markdown source builds
a5921e8 
Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
@actions-user
site deploy
c7c3753 
Auto-generated via {sandpaper}
Source  : a5921e8
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-04 00:40:31 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
@actions-user
markdown source builds
33eb0ce 
Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
@actions-user
site deploy
aee610a 
Auto-generated via {sandpaper}
Source  : 33eb0ce
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-11 00:41:18 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
@actions-user
markdown source builds
7c9901f 
Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
@actions-user
site deploy
446a9f6 
Auto-generated via {sandpaper}
Source  : 7c9901f
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-18 00:41:33 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
@actions-user
markdown source builds
18c9404 
Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
@actions-user
site deploy
57deaef 
Auto-generated via {sandpaper}
Source  : 18c9404
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-25 00:41:04 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e9373d7
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-05-20 16:18:07 +0000
Message : Merge pull request #48 from Selkubi/33-setup-sk

updated draft for setup instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cforgaci cforgaci cforgaci approved these changes

Assignees

@cforgaci cforgaci

@Selkubi Selkubi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update setup instructions
2 participants
@Selkubi @cforgaci