Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution to Ep07 does not work #66

Open
tbooth opened this issue Jul 29, 2024 · 1 comment
Open

Solution to Ep07 does not work #66

tbooth opened this issue Jul 29, 2024 · 1 comment
Labels
reviewer Issues arising from comments on https://github.com/carpentries-lab/reviews/issues/17

Comments

@tbooth
Copy link
Collaborator

tbooth commented Jul 29, 2024

From @cmeesters:

Chapter 7 - Finishing
Again, a nice description. The solution, however, does not work,

and stating in the file # "rule all_counts" has been removed to reduce clutter might seem like a good idea,
but a "solution" for reference should be well tested and complete up to the description in the chapter.

@tbooth tbooth added the reviewer Issues arising from comments on https://github.com/carpentries-lab/reviews/issues/17 label Jul 29, 2024
@tbooth
Copy link
Collaborator Author

tbooth commented Jul 31, 2024

I have now added .github/workflows/code-test-ubuntu.yml and directory of .test/ files which performs a CI test of all the sample solutions. This is not (yet?!) testing solutions embedded in the Markdown, but all files linked at the end of the episodes are auto-tested and confirmed working. Any regressions will be flagged under GitHub Actions. I'm not sure what problem was found with ep07, as the CI test passes without modification.

I disagree with the second comment. The all_counts rule is added at first to demonstrate simple aggregation but is later replaced with the MultiQC rule which performs the aggregation step, so there is no need to keep it in the later answers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewer Issues arising from comments on https://github.com/carpentries-lab/reviews/issues/17
Projects
None yet
Development

No branches or pull requests

1 participant