You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Chapter 7 - Finishing
Again, a nice description. The solution, however, does not work,
and stating in the file # "rule all_counts" has been removed to reduce clutter might seem like a good idea,
but a "solution" for reference should be well tested and complete up to the description in the chapter.
The text was updated successfully, but these errors were encountered:
tbooth
added
the
reviewer
Issues arising from comments on https://github.com/carpentries-lab/reviews/issues/17
label
Jul 29, 2024
I have now added .github/workflows/code-test-ubuntu.yml and directory of .test/ files which performs a CI test of all the sample solutions. This is not (yet?!) testing solutions embedded in the Markdown, but all files linked at the end of the episodes are auto-tested and confirmed working. Any regressions will be flagged under GitHub Actions. I'm not sure what problem was found with ep07, as the CI test passes without modification.
I disagree with the second comment. The all_counts rule is added at first to demonstrate simple aggregation but is later replaced with the MultiQC rule which performs the aggregation step, so there is no need to keep it in the later answers.
From @cmeesters:
The text was updated successfully, but these errors were encountered: