-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPC Episode #18
base: main
Are you sure you want to change the base?
HPC Episode #18
Conversation
…hop into hpc Conflicts: renv/profiles/lesson-requirements/renv.lock
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. Results of any additional workflows will appear here when they are done. |
Co-authored-by: Edward Yang <[email protected]>
Co-authored-by: Edward Yang <[email protected]>
Co-authored-by: Edward Yang <[email protected]>
Co-authored-by: Edward Yang <[email protected]>
Co-authored-by: Edward Yang <[email protected]>
Co-authored-by: Edward Yang <[email protected]>
Conflicts: episodes/hpc.Rmd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments after having gone through the preceding episodes.
Co-authored-by: Edward Yang <[email protected]>
Co-authored-by: Edward Yang <[email protected]>
I realized that I needed to update Can you check if you can still build the HPC lesson locally? I can't because I don't have access to a computer with slurm. (sorry - I realized cherry-pick may not have been the best approach here. Feel free to roll those back and re-base instead if you want) |
I can do that, but can we also test if it's working on the CI? I'm not sure if it actually runs the lesson build for pull requests at the moment? |
Sure - I assume you mean implementing suggestion
|
Oh, I already added that to |
How about this: I just set up another repo and merged GH action is running now... https://github.com/joelnitta/targets-hpc/actions/runs/9867906104 hm, seems to be hung up, I predict it will git killed by time-out. I've actually seen this behavior before, I'm not sure what's causing it but I don't think it is because of this PR... |
No, I think it is a fault in my PR. It's failing at the second workflow which uses different memory requirements, which is likely the issue. I've reduced the memory requirements, but I now realise that it's guaranteed to fail at the GPU workflow since the mini cluster isn't going to have a GPU node. |
ah... so perhaps CI is not an option then? |
Well not for the last workflow, but that's inside a challenge solution so even if I just paste in the pre-computed result there I don't think that's too bad. |
Sounds good, let's try that then. If you push the change here, I can try it again over on my other fork. |
markdown build seems to be hanging |
Yeah, feel free to cancel it. I can't. |
canceled |
I believe this failed because the lesson involves submitting a job that requires 2 GB of RAM, but the |
Actually can you give me the permission to cancel builds so that I can play around with this? |
Okay, putting this on hold until koesterlab/setup-slurm-action#7 is merged. Technically we could use my fork of the action, but there's no hurry. |
This has been written using the current plan writing system. Once/if Code Re-Use #19 is merged, some of this will need re-writing to remove redundancy