Clean up process for adding new nodes

[zkamvar]

There are several places in the code where I add new nodes that need to be cleaned up, because there are so many different ways of doing it, but in reality, all I need to do is to add a node with the same namespace.

Path forward

Some relevant material is at ropensci/tinkr#24 is relevant material here, but an idea is that we have a general node generator that could look like:

make_node <- function(type, ..., ns = "http://commonmark.org/xml/1.0") glue::glue("<{type} {paste(..., collapse = ' ')}></{type}>")
p <- make_node("paragraph")
txt <- make_node("text")
xml2::xml_set_text(txt, "hello there")
xml2::xml_add_child(p, txt)

code <- make_node("code_block", "language='r'", "name='setup'", "eval=FALSE")
xml2::xml_set_text(code, "a <- 1:10\n")

Relevant places in the code

pegboard/R/utils.R

Line 66 in f2155d3

xml_new_paragraph <- function(text = "", ns, tag = TRUE) {

pegboard/R/utils.R

Line 76 in f2155d3

xml_slip_in <- function(body, to_insert, where = length(xml2::xml_children(body))) {

pegboard/R/utils.R

Line 106 in f2155d3

xml_list_chunk <- function(yaml, what, dovetail = TRUE) {

pegboard/R/utils.R

Line 126 in f2155d3

get_setup_chunk <- function(body) {

pegboard/R/fix_links.R

Line 41 in f2155d3

resolve_links <- function(txt, type) {

pegboard/R/div.R

Line 18 in f2155d3

make_div <- function(what) {

pegboard/R/div.R

Line 274 in f2155d3

clean_div_tags <- function(body) {

pegboard/R/div.R

Line 349 in f2155d3

clean_fenced_divs <- function(body) {