Use custom namespace to flag div sections #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is certainly not ready or working, but I've gotten most of the way there by adding custom nodes above and below the delimitors. The snag I'm hitting now is what happens when we mix them.
- label_div_tags has been split into smaller functions - things still don't work at the moment, but we are getting to a better consensus of what things should be
This is the first time the tests pass!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the flags for native and fenced divs in their own namespace. This makes sure that we avoid modification of the document as much as possible (though we still fix native divs because sometimes valid markdown can become trapped in these blocks)
label_div_tags()is now split up intofind_div_tags(),make_div_table(), andadd_pegboard_nodes().clean_fenced_divs()is now deprecated and removed from code coverage calculations because it no longer serves a purpose for our lessons (which is good because that function was >80 lines)get_ns()applies the appropriate prefixes for the namespace (mdfor commonmark, andpbfor pegboard). The output of this function is used in thexml_find_*functions.This pr will fix #16 and address #12