-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update req and all its deps. #12
Conversation
update tests and Adapter setup
mix.lock
Outdated
@@ -2,20 +2,20 @@ | |||
"castore": {:hex, :castore, "1.0.6", "ffc42f110ebfdafab0ea159cd43d31365fa0af0ce4a02ecebf1707ae619ee727", [:mix], [], "hexpm", "374c6e7ca752296be3d6780a6d5b922854ffcc74123da90f2f328996b962d33a"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, if you run mix deps.unlock --unused
, that should remove :castore dependency. Since OTP 25 we have access to OS trust store so this is no longer necessary! (If you use Docker, make sure your images have ca-certificates or similar packages.) On CI you can check if you don't have unused deps with mix deps.unlock --check-unused
.
@@ -724,7 +724,7 @@ defmodule CarReqTest do | |||
) | |||
|
|||
assert_receive {:event, [:http_car_req, :request, :stop], _, | |||
%{reason: %Mint.TransportError{reason: :timeout}}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to update some parts of the code that use this reference, mostly tests and type specs
@@ -680,7 +680,7 @@ defmodule CarReqTest do | |||
)} | |||
end | |||
|
|||
assert {:error, :json_decode_error} = | |||
assert {:error, %Jason.DecodeError{}} = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, there are 3 tests that match this
update tests and Adapter setup
Update req, including:
hpax (MAJOR) https://github.com/elixir-mint/hpax/blob/main/CHANGELOG.md
req https://github.com/wojtekmach/req/blob/main/CHANGELOG.md
finch https://github.com/sneako/finch/blob/main/CHANGELOG.md#changelog