Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update req and all its deps. #12

Merged
merged 2 commits into from
Sep 13, 2024
Merged

update req and all its deps. #12

merged 2 commits into from
Sep 13, 2024

Conversation

ckoch-cars
Copy link
Collaborator

@ckoch-cars ckoch-cars commented Sep 6, 2024

update tests and Adapter setup

Update req, including:
hpax (MAJOR) https://github.com/elixir-mint/hpax/blob/main/CHANGELOG.md

v1.0.0
Silence warnings on Elixir 1.17+.
Require Elixir 1.12+.

req https://github.com/wojtekmach/req/blob/main/CHANGELOG.md
finch https://github.com/sneako/finch/blob/main/CHANGELOG.md#changelog

mix deps.update req
Resolving Hex dependencies...
Resolution completed in 0.02s
Unchanged:
  earmark_parser 1.4.31
  ex_doc 0.29.4
  fuse 2.5.0
  makeup 1.1.0
  makeup_elixir 0.16.1
  makeup_erlang 0.1.1
  nimble_parsec 1.3.0
  nimble_pool 1.1.0
  req_fuse 0.3.0
Upgraded:
  finch 0.18.0 => 0.19.0 (minor)
  hpax 0.1.2 => 1.0.0 (major)
  jason 1.4.1 => 1.4.4
  mime 2.0.5 => 2.0.6
  mint 1.5.2 => 1.6.2
  nimble_options 1.1.0 => 1.1.1
  req 0.4.14 => 0.5.6 (minor)
  telemetry 1.2.1 => 1.3.0

update tests and Adapter setup
mix.lock Outdated
@@ -2,20 +2,20 @@
"castore": {:hex, :castore, "1.0.6", "ffc42f110ebfdafab0ea159cd43d31365fa0af0ce4a02ecebf1707ae619ee727", [:mix], [], "hexpm", "374c6e7ca752296be3d6780a6d5b922854ffcc74123da90f2f328996b962d33a"},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, if you run mix deps.unlock --unused, that should remove :castore dependency. Since OTP 25 we have access to OS trust store so this is no longer necessary! (If you use Docker, make sure your images have ca-certificates or similar packages.) On CI you can check if you don't have unused deps with mix deps.unlock --check-unused.

@@ -724,7 +724,7 @@ defmodule CarReqTest do
)

assert_receive {:event, [:http_car_req, :request, :stop], _,
%{reason: %Mint.TransportError{reason: :timeout}}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to update some parts of the code that use this reference, mostly tests and type specs

@@ -680,7 +680,7 @@ defmodule CarReqTest do
)}
end

assert {:error, :json_decode_error} =
assert {:error, %Jason.DecodeError{}} =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, there are 3 tests that match this

@ckoch-cars ckoch-cars added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit cd011cc Sep 13, 2024
1 check passed
@ckoch-cars ckoch-cars deleted the update_req2 branch September 13, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants