Add msg in engine to inform user of Rsync delay #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macr0Nerd
approved these changes
Dec 9, 2024
npatel-cars
approved these changes
Dec 9, 2024
jagmoreira
added a commit
that referenced
this pull request
Dec 13, 2024
* Split normalize_config into two functions (#27) * Split normalize_config into two functions * Add test cases for normalize_config and parse_additional_config * Bug Fix: on test_parse_additional_config * Update test_parse_additional_config * Added new badges to the Readme (#30) * Move EC2 pricing calls to single function. (#29) * Added more clear SSH error message for improper credentials * Updated changelog * Fixed changelog * Updated SSH credential error message * Add tests for ssh.py module. * Add coverage as a test dependency. * Update changelog and fix style. * Add unittests for rsync module. (#33) * Add tests for yaml_loader.py to increase coverage (#34) * Add tests for yaml_loader.py to increase coverage * remove redundant imports Co-authored-by: ali <[email protected]> * moved function outside for better testing (#35) Co-authored-by: ali <[email protected]> * Added venv to .gitignore * bump version (#37) * Added venv to .gitignore * bump version bump version so we can merge with main * Update CHANGELOG.md update link for unreleased * Update CHANGELOG.md update link for unreleased Co-authored-by: Gabriele A. Ron <[email protected]> * increase test coverage for forge/destory.py (#39) Co-authored-by: ali <[email protected]> * Add a configurable spot strategy * Updated tests * Fixed tests for multi-az * Updated documentation for multi-az * Add multi-az functionality * Add spot retries and failover * Update documentation * Bumped version * Bumped version to 1.1.0 * Updated maintainers * Fixed region bug in create.py * 1.1.1 * Fixed automatic multi-worker allocation bug * Updated dependencies * Added destroy_on_create * Fixed potential bug * Moved to get_nlist() * Version 1.2.0 * Add create_timeout configuration option * Remove default create_timeout setting * Fix create_timeout check * Reduce version to 1.1.0 * Remove Hacktoberfest 2022 branding * GPU Fix (#47) * Fix gpu flag not being parsed properly. * Update changelog. * Add error reporting for RAM/CPU misconfigurations * Add retries and return code to rsync * Bump version to 1.1.1 * Add minute timer after create to engine * Add msg in engine to inform user of Rsync delay (#51) * Add log message to inform user of rsync delay. * Add missing changelog links. * Resolving merge conflicts (#53) * merge dev to main (#38) * Split normalize_config into two functions (#27) * Split normalize_config into two functions * Add test cases for normalize_config and parse_additional_config * Bug Fix: on test_parse_additional_config * Update test_parse_additional_config * Added new badges to the Readme (#30) * Move EC2 pricing calls to single function. (#29) * Added more clear SSH error message for improper credentials * Updated changelog * Fixed changelog * Updated SSH credential error message * Add tests for ssh.py module. * Add coverage as a test dependency. * Update changelog and fix style. * Add unittests for rsync module. (#33) * Add tests for yaml_loader.py to increase coverage (#34) * Add tests for yaml_loader.py to increase coverage * remove redundant imports Co-authored-by: ali <[email protected]> * moved function outside for better testing (#35) Co-authored-by: ali <[email protected]> * Added venv to .gitignore * bump version (#37) * Added venv to .gitignore * bump version bump version so we can merge with main * Update CHANGELOG.md update link for unreleased * Update CHANGELOG.md update link for unreleased Co-authored-by: Gabriele A. Ron <[email protected]> Co-authored-by: Gabe Ron <[email protected]> Co-authored-by: Heshanthaka <[email protected]> Co-authored-by: Joao Moreira <[email protected]> Co-authored-by: Gabriele A. Ron <[email protected]> Co-authored-by: Mohammed Ali Zubair <[email protected]> Co-authored-by: ali <[email protected]> * Add log message to inform user of rsync delay. * Add missing changelog links. * Bump minimum python to 3.9. --------- Co-authored-by: npatel-cars <[email protected]> Co-authored-by: Gabe Ron <[email protected]> Co-authored-by: Heshanthaka <[email protected]> Co-authored-by: Gabriele A. Ron <[email protected]> Co-authored-by: Mohammed Ali Zubair <[email protected]> Co-authored-by: ali <[email protected]> * Update release date. --------- Co-authored-by: Gabe Ron <[email protected]> Co-authored-by: Heshanthaka <[email protected]> Co-authored-by: npatel-cars <[email protected]> Co-authored-by: Gabriele A. Ron <[email protected]> Co-authored-by: Mohammed Ali Zubair <[email protected]> Co-authored-by: ali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.