Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some new subjects #73

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Added some new subjects #73

merged 3 commits into from
Sep 19, 2024

Conversation

DavideCristoni
Copy link
Contributor

No description provided.

Copy link
Contributor

@boozec boozec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we're also considering to use Telegram channels instead of so many groups. Thank you

@foxyseta
Copy link
Member

So are intentionally leaving some of the "chat" fields empty for now? If so, people should be very careful and remember to fill them up us soon as channels/groupchats or whatever are ready.

@DavideCristoni
Copy link
Contributor Author

@foxyseta some of the fields were already empty. For every course that I've added I also created the tg group. I will also create the other 2 missing.

@foxyseta
Copy link
Member

Noce! Want me to accept the PR now or after you are done with the groupchats?

@boozec
Copy link
Contributor

boozec commented Sep 19, 2024

use Telegram channels instead of so many groups

Sorry, mate. I meant "group topics" 😅

teachings.json Outdated Show resolved Hide resolved
@foxyseta
Copy link
Member

use Telegram channels instead of so many groups

Sorry, mate. I meant "group topics" 😅

Group topics still have topic-specific links, so I'd say we'll be able to simply update the links when we'll switch to those. Feel free to open an issue in this repository. Technically, IPIM is already using them. Are their teachings in teachings.json using topics-specific links already?

@foxyseta foxyseta merged commit a561039 into main Sep 19, 2024
2 checks passed
@foxyseta foxyseta mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants