Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new degrees config format #285

Merged
merged 14 commits into from
Jun 7, 2024
Merged

new degrees config format #285

merged 14 commits into from
Jun 7, 2024

Conversation

samuelemusiani
Copy link
Member

No description provided.

@samuelemusiani samuelemusiani requested review from VaiTon and a team as code owners June 6, 2024 15:36
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dynamik ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 11:04am

Copy link
Member

@VaiTon VaiTon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prova a formattare usando prettier, che mi sa che molti spazi sono diversi per quello

src/routes/dash/[course]/+page.svelte Outdated Show resolved Hide resolved
src/routes/dash/[course]/+page.svelte Outdated Show resolved Hide resolved
@samuelemusiani
Copy link
Member Author

Dipende da cartabinaria/config#62

src/lib/teachings.ts Outdated Show resolved Hide resolved
src/lib/teachings.ts Outdated Show resolved Hide resolved
src/routes/+page.svelte Outdated Show resolved Hide resolved
src/routes/[...dir]/[zfile=dir]/+page.svelte Outdated Show resolved Hide resolved
src/routes/build/+page.svelte Outdated Show resolved Hide resolved
src/routes/dash/[course]/+page.svelte Outdated Show resolved Hide resolved
src/routes/dash/[course]/+page.svelte Outdated Show resolved Hide resolved
src/routes/dash/[course]/+page.svelte Outdated Show resolved Hide resolved
@samuelemusiani
Copy link
Member Author

Comunque ho rotto qualcosa sulle dash che non sono info e info magistrale perché sono tutte grige. Non mergiate che provo a fixare

@samuelemusiani
Copy link
Member Author

@VaiTon risolto anche il problema che alcune dash erano tutte grige. Ora mancherebbe il check esplicito sui null che mi hai suggerito. Io non ho problemi a farlo, ma volevo capire se era realmente necessario o più una questione di stile

@foxyseta
Copy link
Member

foxyseta commented Jun 6, 2024

Se è una questione di stile, io preferisco alla Samu.

@VaiTon
Copy link
Member

VaiTon commented Jun 6, 2024

@VaiTon risolto anche il problema che alcune dash erano tutte grige. Ora mancherebbe il check esplicito sui null che mi hai suggerito. Io non ho problemi a farlo, ma volevo capire se era realmente necessario o più una questione di stile

In generale il fatto di utilizzare i valory "truthy" in JS mi da molto fastidio (e non solo a me, c'è un check di eslint fatto apposta), ma se vogliamo tenerlo così mi va bene comunque. Sappiate però che ci sono tanti valori (non solo null e undefined che sono "falsy" secondo JS 1)

Footnotes

  1. https://developer.mozilla.org/en-US/docs/Glossary/Falsy

@samuelemusiani
Copy link
Member Author

Mi fido più di te riguardo a questo, tra stasera e domani faccio i check per i null più espliciti

@samuelemusiani
Copy link
Member Author

@VaiTon direi che ci sono. Mannaggia a js

@VaiTon VaiTon merged commit a0451c0 into main Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants