Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add csunibo favicon and link preview #87

Merged
merged 14 commits into from
Oct 4, 2023
Merged

feat: add csunibo favicon and link preview #87

merged 14 commits into from
Oct 4, 2023

Conversation

ali-benny
Copy link
Member

Add:

  • csunibo favicon
  • meta information for link preview
  • new theme "dracula"

@ali-benny
Add csunibo favicon and link preview
bf8e30f 
Add:
- csunibo favicon
- meta information for link preview
- new theme "dracula"
@vercel
Copy link

vercel bot commented Oct 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dynamik ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 2:15pm

@ali-benny ali-benny linked an issue Oct 4, 2023 that may be closed by this pull request
Anterpima dei link e favicon #7
Closed
@ali-benny ali-benny requested a review from a team October 4, 2023 10:23
@foxyseta
Copy link
Member

foxyseta commented Oct 4, 2023

Per le cartelle e i file io mettrei un anteprima del link specifica. Tipo il titolo potrebbe essere il percorso repo/cartelle/file e la descrizione qualcosa che faccia riferimento all'insegnamento

@VaiTon
Copy link
Member

VaiTon commented Oct 4, 2023

Perché il nuovo tema?

Comunque, al posto di aggiungerlo nell'html lo metterei nel <svelte:head>, in modo tale che sia modificabile dinamicamente per ogni pagina

@ali-benny
Copy link
Member Author

ali-benny commented Oct 4, 2023 •
edited
Loading

Perché il nuovo tema?

Per dare più possibilità?...

Comunque, al posto di aggiungerlo nell'html lo metterei nel <svelte:head>, in modo tale che sia modificabile dinamicamente per ogni pagina

Si infatti, dopo modifico tutto, mi serve fare i commit per vedere se funziona

VaiTon
VaiTon reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@VaiTon VaiTon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inoltre puoi anche mettere nel layout.svelte dei valori di default, in modo tale che per le pagine non /dash/ spunti comunque qualcosa. Poi possiamo anche aggiungere i vari title in ogni pagina "utile".

src/routes/dash/[course]/+page.svelte Outdated Show resolved Hide resolved
src/routes/dash/[course]/+page.svelte Outdated Show resolved Hide resolved
VaiTon
VaiTon reviewed Oct 4, 2023
View reviewed changes
src/app.html Outdated Show resolved Hide resolved
@VaiTon
Copy link
Member

VaiTon commented Oct 4, 2023

@ali-benny ho fatto io, vedi che ne pensi!

@ali-benny
Copy link
Member Author

@ali-benny ho fatto io, vedi che ne pensi!

tolgo i meta che ho aggiunto all'html e li metto nel layout, spero di non aver fatto casino col commit prima, ma prima che tu facessi le tue modifiche stavo per committare ma ho fatto pausa pranzo

@VaiTon
Copy link
Member

VaiTon commented Oct 4, 2023

@ali-benny mi sembra tutto ok! Se puoi mergia main e poi per me è ok!

VaiTon
VaiTon reviewed Oct 4, 2023
View reviewed changes
src/routes/+layout.svelte Outdated Show resolved Hide resolved
@ali-benny
Copy link
Member Author

@VaiTon in che senso conflitto 😢

@VaiTon VaiTon changed the title Add csunibo favicon and link preview feat: add csunibo favicon and link preview Oct 4, 2023
@ali-benny
Copy link
Member Author

scusate, giuro non faccio più modifiche

@ali-benny ali-benny merged commit 6ba6a02 into main Oct 4, 2023
4 checks passed
@ali-benny ali-benny deleted the favicon-preview branch October 5, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaiTon VaiTon VaiTon left review comments

@foxyseta foxyseta foxyseta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anterpima dei link e favicon
3 participants
@ali-benny @foxyseta @VaiTon