Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forward application exit status #131

Closed
wants to merge 1 commit into from

Conversation

mpolitzer
Copy link
Contributor

@mpolitzer mpolitzer commented Aug 24, 2023

After reviews, no change is required here ...

Exit with success:

cartesi-machine.lua -- true

         .
        / \
      /    \
\---/---\  /----\
 \       X       \
  \----/  \---/---\
       \    / CARTESI
        \ /   MACHINE
         '


Halted
Cycles: 36366527

Exit with "Nothing to do" is the same as success:

cartesi-machine.lua

         .
        / \
      /    \
\---/---\  /----\
 \       X       \
  \----/  \---/---\
       \    / CARTESI
        \ /   MACHINE
         '

Nothing to do.

Halted
Cycles: 33157931

Exit with failure:

cartesi-machine.lua -- false

         .
        / \
      /    \
\---/---\  /----\
 \       X       \
  \----/  \---/---\
       \    / CARTESI
        \ /   MACHINE
         '

[    0.198528] reboot: Restarting system with command '1'

Halted with payload: 1
Cycles: 35773807

Exit with an invalid code:

cartesi-machine.lua --append-rom-bootargs='single=yes' -- xhalt something_invalid

         .
        / \
      /    \
\---/---\  /----\
 \       X       \
  \----/  \---/---\
       \    / CARTESI
        \ /   MACHINE
         '

[    0.202688] reboot: Restarting system with command 'something_invalid'

Halted with payload: 4294967296
Cycles: 36340263

close #55

@mpolitzer mpolitzer requested a review from a team August 24, 2023 18:36
@mpolitzer mpolitzer self-assigned this Aug 24, 2023
@mpolitzer mpolitzer added the enhancement New feature or request label Aug 24, 2023
@mpolitzer mpolitzer force-pushed the feature/forwad-application-exit-status branch from e3c8561 to 7889d2b Compare August 24, 2023 19:45
@mpolitzer mpolitzer force-pushed the feature/forwad-application-exit-status branch from 7889d2b to 02be7e9 Compare September 22, 2023 15:11
@mpolitzer mpolitzer marked this pull request as ready for review September 22, 2023 15:17
@mpolitzer mpolitzer force-pushed the feature/forwad-application-exit-status branch from 02be7e9 to 0eba548 Compare September 22, 2023 15:25
@mpolitzer
Copy link
Contributor Author

No change needed here to support this feature

@mpolitzer mpolitzer closed this Sep 22, 2023
@mpolitzer mpolitzer deleted the feature/forwad-application-exit-status branch September 22, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward application exit status to host
1 participant