Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move constants to namespace to avoid colision #142

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: move constants to namespace to avoid colision #142

merged 1 commit into from
Oct 9, 2023

Conversation

diegonehab
Copy link
Contributor

ThePAGE_SIZE constant in test-utils.h was declared in the global namespace was colliding with the same identifier declared by vm_param.h when compiling on a Mac. This PR moves the constant to the detail namespace so it is kept separate.

@diegonehab diegonehab requested a review from vfusco October 9, 2023 15:27
@vfusco vfusco added bug Something isn't working enhancement New feature or request labels Oct 9, 2023
@vfusco vfusco added this to the v0.16.0 milestone Oct 9, 2023
@diegonehab diegonehab merged commit cc52626 into main Oct 9, 2023
7 checks passed
@diegonehab diegonehab deleted the feature/remove-defines branch October 9, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfusco vfusco vfusco approved these changes

@mpernambuco mpernambuco mpernambuco approved these changes

@edubart edubart Awaiting requested review from edubart

Assignees

@diegonehab diegonehab

Labels
bug Something isn't working enhancement New feature or request
Projects
Machine Emulator SDK
Status: Done
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@diegonehab @mpernambuco @vfusco