Feature/simplify #298
Merged
Feature/simplify #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonrpc_request has a bunch of arguments that are always the same and are members of jsonrpc_virtual_machine object. add request method to jsonrpc_virtual_machine that simply passes them along. rewrite all other methdos to call simpler request instead of jsonrpc_request.
diegonehab
force-pushed
the
feature/simplify
branch
from
7e005c3 to
17d43da
Compare
diegonehab
force-pushed
the
feature/simplify
branch
from
17d43da to
407fa87
Compare
mpernambuco
approved these changes
Dec 21, 2024
edubart
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the state_access classes so we are not forced to implement so many methods whenever we have a new one.