Remove inspect api #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gligneul
suggested changes
Jan 11, 2024
There was a problem hiding this comment.
Please fix the makefile:
➜ openapi-interfaces git:(50a38b7) make
rm -rf docs/rollup
java -jar swagger-codegen-cli.jar generate -l html2 -i rollup.yaml -o docs/rollup
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
make: *** No rule to make target 'docs/inspect', needed by 'all'. Stop.
Probably just needs to adjust this line: https://github.com/cartesi/openapi-interfaces/blob/main/Makefile#L18
Please test.
4 tasks
GMKrieger
force-pushed
the
chore/remove-inspect-api
branch
from
47ed173 to
a5a3802
Compare
gligneul
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inspect API is being moved inside the rollups-node on this PR cartesi/rollups-node#239. Therefore, it isn't needed here.