Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#275 Make specs preview section sticky #276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nevendyulgerov
Copy link
Contributor

I made the preview section sticky so that it's visible at all times.

@nevendyulgerov nevendyulgerov added Type: Enhancement Improve an existing feature / design apps: web labels Dec 10, 2024
@nevendyulgerov nevendyulgerov self-assigned this Dec 10, 2024
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-arbitrum-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:41am
rollups-explorer-arbitrum-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:41am
rollups-explorer-base-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:41am
rollups-explorer-base-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:41am
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:41am
rollups-explorer-optimism-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:41am
rollups-explorer-optimism-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:41am
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:41am
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:41am

@nevendyulgerov nevendyulgerov linked an issue Dec 10, 2024 that may be closed by this pull request
1 task
@@ -15,7 +15,7 @@ export const DecodingPreview = () => {
const content = envelope?.result ? stringifyContent(envelope.result) : null;

return (
<Card shadow="sm" withBorder>
<Card shadow="sm" withBorder pos="sticky" top="4.75rem">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nevendyulgerov, regarding the top attribute, what do you think about getting that number from the theme? It has the components -> AppShell and config for the header's height. Then, a sum could be done to offset and keep the spacing stable even if the height of header changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Type: Enhancement Improve an existing feature / design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the specifications preview section sticky
2 participants