feat(database): Add Epoch and Snapshot tables #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoura
force-pushed
the
feature/repository-add-epoch
branch
from
42f5266 to
968c971
Compare
fmoura
force-pushed
the
feature/repository-add-epoch
branch
6 times, most recently
from
bc74f44 to
1225eaa
Compare
fmoura
force-pushed
the
feature/repository-add-epoch
branch
from
1225eaa to
5e9f73c
Compare
renan061
requested changes
Aug 6, 2024
.../repository/migrations/000001_create_application_input_claim_output_report_nodeconfig.up.sql
Outdated
Show resolved
Hide resolved
GMKrieger
requested changes
Aug 6, 2024
There was a problem hiding this comment.
I was going to comment that the snapshot table doesn't test fail cases, but reading the models, it doesn't have one.
We need to make some changes. We accept same app address and input? If yes, we need to change how we get snapshots. If no, we need to add an unique constraint to this columns.
.../repository/migrations/000001_create_application_input_claim_output_report_nodeconfig.up.sql
Show resolved
Hide resolved
internal/repository/migrations/000002_create_postgraphile_view.up.sql
Outdated
Show resolved
Hide resolved
fmoura
force-pushed
the
feature/repository-add-epoch
branch
from
13cbb90 to
abc3376
Compare
Index uniqueness per application will be checked on issue #556 |
fmoura
force-pushed
the
feature/repository-add-epoch
branch
from
e215ce0 to
c118266
Compare
fmoura
force-pushed
the
feature/repository-add-epoch
branch
from
22a7810 to
8a39aee
Compare
GMKrieger
approved these changes
Aug 12, 2024
vfusco
approved these changes
Aug 13, 2024
fmoura
force-pushed
the
feature/repository-add-epoch
branch
from
8a39aee to
94d13b8
Compare
renan061
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #544