Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kh dev #461

Merged
merged 19 commits into from
Sep 16, 2023
Merged

Kh dev #461

merged 19 commits into from
Sep 16, 2023

Conversation

kennethshsu
Copy link
Collaborator

  • Separated workbooks (now blank with solutions)
  • Fixed URLs to open workbooks

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c5c0a10) 81.65% compared to head (3d40046) 81.65%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   81.65%   81.65%           
=======================================
  Files          80       80           
  Lines        4711     4711           
  Branches      806      806           
=======================================
  Hits         3847     3847           
  Misses        660      660           
  Partials      204      204           
Flag Coverage Δ
unittests 81.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbogaardt
Copy link
Collaborator

I've cleared this, but it has a merge conflict. Not sure which docs you want. Can you resolve the conflict @kennethshsu

@kennethshsu
Copy link
Collaborator Author

For some reason, my VS conflict resolver isn't working properly... It should be good now.

Also, is it best practice to get rid of a branch after every approved PR? I see that all the old commit history records are still there, and showing up again after a new PR, even after a prior commit had already been approved.

@kennethshsu kennethshsu merged commit af9c679 into master Sep 16, 2023
6 checks passed
@kennethshsu
Copy link
Collaborator Author

For some reason, my VS conflict resolver isn't working properly... It should be good now.

Also, is it best practice to get rid of a branch after every approved PR? I see that all the old commit history records are still there, and showing up again after a new PR, even after a prior commit had already been approved.

Ahh, I think I know why now, because even though you approved the PR, it wasn't actually merged, until just now right?

@kennethshsu
Copy link
Collaborator Author

There are still some issues with the current version, I should've had committed it yet.

@kennethshsu kennethshsu mentioned this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants