-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kh dev #461
Kh dev #461
Conversation
kennethshsu
commented
Sep 15, 2023
- Separated workbooks (now blank with solutions)
- Fixed URLs to open workbooks
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
=======================================
Coverage 81.65% 81.65%
=======================================
Files 80 80
Lines 4711 4711
Branches 806 806
=======================================
Hits 3847 3847
Misses 660 660
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I've cleared this, but it has a merge conflict. Not sure which docs you want. Can you resolve the conflict @kennethshsu |
For some reason, my VS conflict resolver isn't working properly... It should be good now. Also, is it best practice to get rid of a branch after every approved PR? I see that all the old commit history records are still there, and showing up again after a new PR, even after a prior commit had already been approved. |
Ahh, I think I know why now, because even though you approved the PR, it wasn't actually merged, until just now right? |
There are still some issues with the current version, I should've had committed it yet.
|