Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update go-pg to overcome SASL error #50

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

SayakMukhopadhyay
Copy link
Contributor

@SayakMukhopadhyay SayakMukhopadhyay commented Jan 26, 2024

This PR updated go-pg to overcome a SASL error as in go-pg/pg#1483. Closes #49

Fix: #49

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2024

CLA assistant check
All committers have signed the CLA.

@SayakMukhopadhyay
Copy link
Contributor Author

Not sure about the cause of the test failure. The error says ../../../go/pkg/mod/github.com/tmthrgd/[email protected]/hex_amd64.go:10:8: C source files not allowed when not using cgo or SWIG: cpu_gccgo_x86.c but go-hex hasn't undergone any update.

@hsluoyz hsluoyz closed this Jan 26, 2024
@hsluoyz hsluoyz reopened this Jan 26, 2024
@hsluoyz
Copy link
Member

hsluoyz commented Jan 26, 2024

@SayakMukhopadhyay can you rebase this PR?

@SayakMukhopadhyay
Copy link
Contributor Author

@hsluoyz rebased and tested locally

@hsluoyz hsluoyz changed the title fix: updated go-pg to overcome SASL error feat: update go-pg to overcome SASL error Jan 26, 2024
@hsluoyz hsluoyz merged commit 1dea951 into casbin:master Jan 26, 2024
4 checks passed
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update go-pg to ensure SCRAM-SHA-256-PLUS support
3 participants