Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix the CI dockerhub release error #118

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

ali-shokoohi
Copy link
Contributor

@ali-shokoohi ali-shokoohi commented Oct 1, 2024

Fix: #117

Because of this project is using golang version 1.19, We should choice a good versions for packages.

Changes:

  • Changed version of google.golang.org/protobuf/cmd/protoc-gen-go from @latest to @v1.28.0
  • Changed version of google.golang.org/protobuf/cmd/protoc-gen-go from @latest to @v1.2.0
  • Download modules with go mod download command instead of downloading packages with latest versions like: "RUN go get google.golang.org/grpc"

Because of this project is using golang version 1.19, We should choice a good versions for packages.

Changes:
- Changed version of google.golang.org/protobuf/cmd/protoc-gen-go from @latest to @v1.28.0
- Changed version of google.golang.org/protobuf/cmd/protoc-gen-go from @latest to @v1.2.0
- Download modules with `go mod download` command instead of downloading packages with latest versions like: "RUN go get google.golang.org/grpc"
@coveralls
Copy link

Coverage Status

coverage: 69.072%. remained the same
when pulling 1f5604f on ali-shokoohi:fix/fix-versions-in-dockerfile
into 3874663 on casbin:master.

@hsluoyz hsluoyz changed the title fix: fixed the CI dockerhub release error #117 feat: fix the CI dockerhub release error Oct 1, 2024
@hsluoyz hsluoyz merged commit 8d65648 into casbin:master Oct 1, 2024
5 checks passed
Copy link

github-actions bot commented Oct 1, 2024

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] fix the CI dockerhub release error
3 participants