Fixed checkAll event bug with sortable checkbox field

casdolfo · Nov 13, 2019 · af2ed31 · af2ed31
1 parent e3f5dae
commit af2ed31
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ ChangeLog
 - **Update:** Fixed `pageSize` set to all bug with filter.
 - **Update:** Fixed `jqXHR` `undefined` error using custom ajax.
 - **Update:** Fixed `refreshOptions` bug with radio and checkbox.
+- **Update:** Fixed `checkAll` event bug with sortable checkbox field.
 - **Update:** Fixed checkbox and not-found td style errors.
 - **Update:** Fixed `hideUnusedSelectOptions` not work bug for filter-control extension.
 - **Update:** Fixed `virtualScroll` option bug with treegrid extension.

diff --git a/src/bootstrap-table.js b/src/bootstrap-table.js
@@ -360,8 +360,9 @@ class BootstrapTable {
     }
 
     this.$selectAll = this.$header.find('[name="btSelectAll"]')
-    this.$selectAll.off('click').on('click', ({currentTarget}) => {
-      const checked = $(currentTarget).prop('checked')
+    this.$selectAll.off('click').on('click', e => {
+      e.stopPropagation()
+      const checked = $(e.currentTarget).prop('checked')
       this[checked ? 'checkAll' : 'uncheckAll']()
       this.updateSelected()
     })