Issue 5 message thread #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
that referenced
this pull request
Mar 12, 2024
This patch is an isolated and expanded change drawn from PR 38. This patch was written to integrate into the current class hierarchy without disruption to existing code. This patch does not necessarily indicate agreement with the current class hierarchy. A follow-on patch will regenerate Make-managed files. References: * #38 Signed-off-by: Alex Nelson <[email protected]>
Merged
|
I'm addressing the merge conflict now. |
Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Examples
that referenced
this pull request
Mar 13, 2024
Reported in CASE-Mapping-Python PR 38. No effects were observed on Make-managed files. References: * casework/CASE-Mapping-Python#38 Reported-by: Fabrizio Turchi <[email protected]> Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Examples
that referenced
this pull request
Mar 13, 2024
`uco-observable:displayName` is not associated with `uco-observable:MessageThreadFacet` by a SHACL property shape, at the time of UCO 1.3.0. Nothing encoded in UCO disallows the way it was used in `message.json`, but the data stored in that property is being removed to follow the suggestions from the SHACL shapes. Reported in CASE-Mapping-Python PR 38. No effects were observed on Make-managed files. References: * casework/CASE-Mapping-Python#38 Reported-by: Fabrizio Turchi <[email protected]> Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5 issue, I changed the FacetMessagethread class. The class doesn't generate a complex structure as illustrated in the message example:
https://github.com/casework/CASE-Examples/blob/master/examples/illustrations/message/message.json).
The class takes into consideration the list of participants (array of Account ObservableObject), the list of messages (array of Message ObservableObjects) and the visibility.
BTW, the example on the repo should be slightly updated replacing the properties:
"uco-observable:displayName": "Best Friend Chat!!" --> uco-core:name outside of the uco-core:hasFacet array and
"drafting:visibility": "PRIVATE" --> boolean value False.